From: Oleksij Rempel <linux@rempel-privat.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org,
jason@lakedaemon.net, marc.zyngier@arm.com
Subject: Re: [PATCH] irqchip: mxs: add missing set_handle_irq()
Date: Fri, 29 Jan 2016 09:49:08 +0100 [thread overview]
Message-ID: <56AB2784.2090205@rempel-privat.de> (raw)
In-Reply-To: <alpine.DEB.2.11.1601290932250.3886@nanos>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
Am 29.01.2016 um 09:33 schrieb Thomas Gleixner:
> On Fri, 29 Jan 2016, Oleksij Rempel wrote:
>
>> this will fix IRQ related issues on Alphascale ASM9260
>
> This really does not qualify as a changelog.
>
> 1) What's the problem and what consequences does it have
>
> 2) What's the fix.
>
> Thanks,
>
> tglx
>
The driver provide this function:
asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)
{
u32 irqnr;
irqnr = __raw_readl(icoll_priv.stat);
__raw_writel(irqnr, icoll_priv.vector);
handle_domain_irq(icoll_domain, irqnr, regs);
}
i assume at some late review point instead of move it to asm9260_of_init
i removed it completely. As result, the driver was compilable but not
working.
Should i put this explanation to changelog?
--
Regards,
Oleksij
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
next prev parent reply other threads:[~2016-01-29 8:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 8:29 [PATCH] irqchip: mxs: add missing set_handle_irq() Oleksij Rempel
2016-01-29 8:33 ` Thomas Gleixner
2016-01-29 8:49 ` Oleksij Rempel [this message]
2016-01-29 8:54 ` Thomas Gleixner
2016-01-29 8:58 ` Oleksij Rempel
2016-01-29 9:16 ` Thomas Gleixner
2016-01-29 9:57 ` [PATCH v2] " Oleksij Rempel
2016-01-29 11:18 ` [tip:irq/urgent] irqchip/mxs: Add " tip-bot for Oleksij Rempel
2016-02-17 22:17 ` [PATCH v2] irqchip: mxs: add " Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AB2784.2090205@rempel-privat.de \
--to=linux@rempel-privat.de \
--cc=jason@lakedaemon.net \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.