From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shubhangi Shrivastava Subject: Re: [PATCH 2/5] drm/i915: Cleaning up intel_dp_hpd_pulse Date: Fri, 29 Jan 2016 14:31:50 +0530 Message-ID: <56AB2A7E.6030403@intel.com> References: <1453199833-10401-1-git-send-email-shubhangi.shrivastava@intel.com> <1453199833-10401-2-git-send-email-shubhangi.shrivastava@intel.com> <1453814570.2695.18.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 4AAE26E933 for ; Fri, 29 Jan 2016 00:58:44 -0800 (PST) In-Reply-To: <1453814570.2695.18.camel@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan De Oliveira , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiBUdWVzZGF5IDI2IEphbnVhcnkgMjAxNiAwNjo1MiBQTSwgQW5kZXIgQ29uc2VsdmFuIERl IE9saXZlaXJhIHdyb3RlOgo+IE9uIFR1ZSwgMjAxNi0wMS0xOSBhdCAxNjowNyArMDUzMCwgU2h1 YmhhbmdpIFNocml2YXN0YXZhIHdyb3RlOgo+PiBDdXJyZW50IERQIGRldGVjdGlvbiBoYXMgRFBD RCBvcGVyYXRpb25zIHNwbGl0IGFjcm9zcwo+PiBpbnRlbF9kcF9ocGRfcHVsc2UgYW5kIGludGVs X2RwX2RldGVjdCB3aGljaCBjb250YWlucwo+PiBkdXBsaWNhdGVzIGFzIHdlbGwuIEFsc28gaW50 ZWxfZHBfZGV0ZWN0IGlzIGNhbGxlZAo+PiBkdXJpbmcgbW9kZXMgZW51bWVyYXRpb24gYXMgd2Vs bCB3aGljaCB3aWxsIHJlc3VsdAo+PiBpbiBtdWx0aXBsZSBkcGNkIG9wZXJhdGlvbnMuIFNvIHRo aXMgcGF0Y2ggdHJpZXMKPj4gdG8gc29sdmUgYm90aCB0aGVzZSBieSBicmluZ2luZyBhbGwgRFBD RCBvcGVyYXRpb25zCj4+IGluIG9uZSBzaW5nbGUgZnVuY3Rpb24gYW5kIG1ha2UgaW50ZWxfZHBf ZGV0ZWN0Cj4+IHVzZSBleGlzdGluZyB2YWx1ZXMgaW5zdGVhZCBvZiByZXBlYXRpbmcgc2FtZSBz dGVwcy4KPj4KPj4gdjI6IFB1bGxlZCBpbiBhIGh1bmsgZnJvbSBsYXN0IHBhdGNoIG9mIHRoZSBz ZXJpZXMgdG8KPj4gICAgICB0aGlzIHBhdGNoLiAoQW5kZXIpCj4+IHYzOiBBZGRlZCBNU1QgaG90 cGx1ZyBoYW5kbGluZy4gKEFuZGVyKQo+Pgo+PiBUZXN0ZWQtYnk6IE5hdGhhbiBEIENpb2JhbnUg PG5hdGhhbi5kLmNpb2JhbnVAaW50ZWwuY29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBTaXZha3VtYXIg VGh1bGFzaW1hbmkgPHNpdmFrdW1hci50aHVsYXNpbWFuaUBpbnRlbC5jb20+Cj4+IFNpZ25lZC1v ZmYtYnk6IFNodWJoYW5naSBTaHJpdmFzdGF2YSA8c2h1YmhhbmdpLnNocml2YXN0YXZhQGludGVs LmNvbT4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyB8IDcxICsr KysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPj4gLQo+PiAgIDEgZmlsZSBj aGFuZ2VkLCA0NCBpbnNlcnRpb25zKCspLCAyNyBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcC5jCj4+IGluZGV4IDg5NjlmZjkuLjgyZWUxOGQgMTAwNjQ0Cj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHAuYwo+IFsuLi5dCj4KPj4gQEAgLTQ2OTMsNyArNDcxNyw4IEBAIGludGVsX2Rw X2RldGVjdChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLCBib29sCj4+IGZvcmNlKQo+ PiAgIAkJcmV0dXJuIGNvbm5lY3Rvcl9zdGF0dXNfZGlzY29ubmVjdGVkOwo+PiAgIAl9Cj4+ICAg Cj4+IC0JaW50ZWxfZHBfbG9uZ19wdWxzZShpbnRlbF9kcC0+YXR0YWNoZWRfY29ubmVjdG9yKTsK Pj4gKwlpZiAoZm9yY2UpCj4+ICsJCWludGVsX2RwX2xvbmdfcHVsc2UoaW50ZWxfZHAtPmF0dGFj aGVkX2Nvbm5lY3Rvcik7Cj4gSSBkaWRuJ3Qgbm90aWNlIHRoaXMgYXQgZmlyc3QsIGJ1dCBmb3Jj ZSBpcyBub3QgdGhlIHJpZ2h0IHRoaW5nIHRvIGNoZWNrIGZvcgo+IGhlcmUuIEl0IGlzIGJhc2lj YWxseSBpbnRlbmRlZCB0byBhdm9pZCBkb2luZyBsb2FkIGRldGVjdGlvbiAoc2VlCj4gaW50ZWxf Z2V0X2xvYWRfZGV0ZWN0X3BpcGUoKSkgb24gYXV0b21hdGVkIHBvbGxpbmcuIEJ1dCB3ZSBzdGls bCBoYXZlIHRvIHRyeQo+IGRldGVjdGlvbiBoZXJlIHdoZW4gZm9yY2UgPSBmYWxzZSwgb3RoZXJ3 aXNlIHRoaXMgd2lsbCBjYXVzZSBhIHJlZ3Jlc3Npb24uCj4KPiBJZiB5b3UgcGx1ZyBpbiBhIERQ IGRldmljZSB3aGlsZSBzdXNwZW5kZWQsIHRoYXQgZGV2aWNlIHdvbid0IGdldCBkZXRlY3RlZCwK PiBzaW5jZSB3ZSBkb24ndCBnZXQgYW4gSFBEIGZvciBpdC4gUHJldmlvdXNseSwgdGhlIGNhbGwg ZG8gaW50ZWxfZHBfZGV0ZWN0KCkgd2l0aAo+IGZvcmNlID0gZmFsc2UgZnJvbSBpbnRlbF9kcm1f cmVzdW1lKCkgKHZpYSBkcm1faGVscGVyX2hwZF9pcnFfZXZlbnQoKSkgd291bGQKPiBjYXVzZSBh IGZ1bGwgZGV0ZWN0aW9uLgo+Cj4gVG8gYXZvaWQgdGhlIHJlcGVhdGVkIERQQ0Qgb3BlcmF0aW9u cywgSSB0aGluayB3ZSBuZWVkIGEgbW9yZSBleHBsaWNpdCBtZWNoYW5pc20KPiB0byBzaWduYWwg dGhhdCB3ZSBhbHJlYWR5IGhhbmRsZWQgdGhlIGxvbmcgcHVsc2UgdmlhIHRoZSBIUEQgaGFuZGxl ci4gSW4KPiBpbnRlbF9kcF9ocGRfcHVsc2UoKSB3ZSBjb3VsZCBzZXQgYSBmbGFnIHRoYXQgdGVs bHMgd2UganVzdCBoYW5kbGVkIGEgbG9uZyBwdWxzZQo+IGZvciB0aGUgZ2l2ZW4gcG9ydC4gVGhl IGNhbGwgdG8gaW50ZWxfZHBfbG9uZ19wdWxzZSgpIGluIGludGVsX2RwX2RldGVjdCgpIHdvdWxk Cj4gdGhlbiBiZSBkZXBlbmRlbnQgb24gdGhhdCBmbGFnLgo+Cj4gRm9yIHRoYXQgcmVhc29uIEkg aGF2ZSB0byByZXRyYWN0IG15IFItYiBmcm9tIHRoaXMgcGF0Y2guCj4KPiBBbmRlcgoKQ2FsbCB0 byBpbnRlbF9kcF9kZXRlY3QoKSBmcm9tIGdldF9tb2RlcyBpcyB3aXRoIGZvcmNlIHNldCB0byB0 cnVlIHdoaWxlIApmcm9tIHJlc3VtZSB0aGUgY2FsbCBpcyB3aXRoIGZvcmNlIHNldCB0byBmYWxz ZS4uIEl0IHNob3VsZCBiZSBpbiB0aGUgCm9wcG9zaXRlIG1hbm5lciBhcyBnZXRfbW9kZXMgc2hv dWxkIG5vdCByZXF1aXJlIGZ1bGwgZGV0ZWN0aW9uIHdoZXJlYXMgCnJlc3VtZSBzaG91bGQuIFNv LCB0aGlzIG5lZWRzIHRvIGJlIGNsZWFuZWQgdXAgdGhlcmUuIEFmdGVyIG1lcmdlIG9mIAp0aGVz ZSBwYXRjaGVzLCB3aWxsIGxvb2sgaW50byBjbGVhbmluZyB1cCB0aGF0IHBhcnQgb2YgdGhlIGNv ZGUuCgpNb3Jlb3ZlciwgaW50ZWxfZHBfZGV0ZWN0KCkgd2lsbCBiZSBjYWxsZWQgZnJvbSAKZHJt X2hlbHBlcl9ocGRfaXJxX2V2ZW50KCkgaW4gcG9sbGluZyBzY2VuYXJpb3Mgb25seSAod2hlbiAK RFJNX0NPTk5FQ1RPUl9QT0xMX0hQRCBmbGFnIGlzIHNldCBpbiBjb25uZWN0b3ItPnBvbGxlZCku IFNvLCBzZWVtcyBsaWtlIAp0aGlzIGNvZGUgaGVyZSwgZG9lc24ndCByZWFsbHkgY3JlYXRlIGEg cmVncmVzc2lvbiBmb3IgcmVhbHRpbWUgc2NlbmFyaW9zLgoKPiAgIAo+PiAgIAlpZiAoaW50ZWxf Y29ubmVjdG9yLT5kZXRlY3RfZWRpZCkKPj4gICAJCXJldHVybiBjb25uZWN0b3Jfc3RhdHVzX2Nv bm5lY3RlZDsKPj4gQEAgLTUwMjYsMjUgKzUwNTEsMjUgQEAgaW50ZWxfZHBfaHBkX3B1bHNlKHN0 cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQKPj4gKmludGVsX2RpZ19wb3J0LCBib29sIGxvbmdfaHBk KQo+PiAgIAkJLyogaW5kaWNhdGUgdGhhdCB3ZSBuZWVkIHRvIHJlc3RhcnQgbGluayB0cmFpbmlu ZyAqLwo+PiAgIAkJaW50ZWxfZHAtPnRyYWluX3NldF92YWxpZCA9IGZhbHNlOwo+PiAgIAo+PiAt CQlpZiAoIWludGVsX2RpZ2l0YWxfcG9ydF9jb25uZWN0ZWQoZGV2X3ByaXYsIGludGVsX2RpZ19w b3J0KSkKPj4gLQkJCWdvdG8gbXN0X2ZhaWw7Cj4+IC0KPj4gLQkJaWYgKCFpbnRlbF9kcF9nZXRf ZHBjZChpbnRlbF9kcCkpIHsKPj4gLQkJCWdvdG8gbXN0X2ZhaWw7Cj4+IC0JCX0KPj4gLQo+PiAt CQlpbnRlbF9kcF9wcm9iZV9vdWkoaW50ZWxfZHApOwo+PiArCQlpbnRlbF9kcF9sb25nX3B1bHNl KGludGVsX2RwLT5hdHRhY2hlZF9jb25uZWN0b3IpOwo+PiArCQlpZiAoaW50ZWxfZHAtPmlzX21z dCkKPj4gKwkJCXJldCA9IElSUV9IQU5ETEVEOwo+PiArCQlnb3RvIHB1dF9wb3dlcjsKPj4gICAK Pj4gLQkJaWYgKCFpbnRlbF9kcF9wcm9iZV9tc3QoaW50ZWxfZHApKSB7Cj4+IC0JCQlkcm1fbW9k ZXNldF9sb2NrKCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgsCj4+IE5VTEwpOwo+ PiAtCQkJaW50ZWxfZHBfY2hlY2tfbGlua19zdGF0dXMoaW50ZWxfZHApOwo+PiAtCQkJZHJtX21v ZGVzZXRfdW5sb2NrKCZkZXYKPj4gLT5tb2RlX2NvbmZpZy5jb25uZWN0aW9uX211dGV4KTsKPj4g LQkJCWdvdG8gbXN0X2ZhaWw7Cj4+IC0JCX0KPj4gICAJfSBlbHNlIHsKPj4gICAJCWlmIChpbnRl bF9kcC0+aXNfbXN0KSB7Cj4+IC0JCQlpZiAoaW50ZWxfZHBfY2hlY2tfbXN0X3N0YXR1cyhpbnRl bF9kcCkgPT0gLUVJTlZBTCkKPj4gLQkJCQlnb3RvIG1zdF9mYWlsOwo+PiArCQkJaWYgKGludGVs X2RwX2NoZWNrX21zdF9zdGF0dXMoaW50ZWxfZHApID09IC1FSU5WQUwpIHsKPj4gKwkJCQkvKgo+ PiArCQkJCSAqIElmIHdlIHdlcmUgaW4gTVNUIG1vZGUsIGFuZCBkZXZpY2UgaXMgbm90Cj4+ICsJ CQkJICogdGhlcmUsIGdldCBvdXQgb2YgTVNUIG1vZGUKPj4gKwkJCQkgKi8KPj4gKwkJCQlEUk1f REVCVUdfS01TKCJNU1QgZGV2aWNlIG1heSBoYXZlCj4+IGRpc2FwcGVhcmVkICVkIHZzICVkXG4i LAo+PiArCQkJCQlpbnRlbF9kcC0+aXNfbXN0LCBpbnRlbF9kcAo+PiAtPm1zdF9tZ3IubXN0X3N0 YXRlKTsKPj4gKwkJCQlpbnRlbF9kcC0+aXNfbXN0ID0gZmFsc2U7Cj4+ICsJCQkJZHJtX2RwX21z dF90b3BvbG9neV9tZ3Jfc2V0X21zdCgmaW50ZWxfZHAKPj4gLT5tc3RfbWdyLAo+PiArCQkJCQkJ CQlpbnRlbF9kcAo+PiAtPmlzX21zdCk7Cj4+ICsJCQkJZ290byBwdXRfcG93ZXI7Cj4+ICsJCQl9 Cj4+ICAgCQl9Cj4+ICAgCj4+ICAgCQlpZiAoIWludGVsX2RwLT5pc19tc3QpIHsKPj4gQEAgLTUw NTYsMTQgKzUwODEsNiBAQCBpbnRlbF9kcF9ocGRfcHVsc2Uoc3RydWN0IGludGVsX2RpZ2l0YWxf cG9ydAo+PiAqaW50ZWxfZGlnX3BvcnQsIGJvb2wgbG9uZ19ocGQpCj4+ICAgCj4+ICAgCXJldCA9 IElSUV9IQU5ETEVEOwo+PiAgIAo+PiAtCWdvdG8gcHV0X3Bvd2VyOwo+PiAtbXN0X2ZhaWw6Cj4+ IC0JLyogaWYgd2Ugd2VyZSBpbiBNU1QgbW9kZSwgYW5kIGRldmljZSBpcyBub3QgdGhlcmUgZ2V0 IG91dCBvZiBNU1QKPj4gbW9kZSAqLwo+PiAtCWlmIChpbnRlbF9kcC0+aXNfbXN0KSB7Cj4+IC0J CURSTV9ERUJVR19LTVMoIk1TVCBkZXZpY2UgbWF5IGhhdmUgZGlzYXBwZWFyZWQgJWQgdnMgJWRc biIsCj4+IGludGVsX2RwLT5pc19tc3QsIGludGVsX2RwLT5tc3RfbWdyLm1zdF9zdGF0ZSk7Cj4+ IC0JCWludGVsX2RwLT5pc19tc3QgPSBmYWxzZTsKPj4gLQkJZHJtX2RwX21zdF90b3BvbG9neV9t Z3Jfc2V0X21zdCgmaW50ZWxfZHAtPm1zdF9tZ3IsIGludGVsX2RwCj4+IC0+aXNfbXN0KTsKPj4g LQl9Cj4+ICAgcHV0X3Bvd2VyOgo+PiAgIAlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJp diwgcG93ZXJfZG9tYWluKTsKPj4gICAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==