All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Jens Axboe <axboe@fb.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <Linux-scsi@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: blk-mq and interrupt affinity
Date: Fri, 29 Jan 2016 10:40:27 +0100	[thread overview]
Message-ID: <56AB338B.4020804@suse.de> (raw)

Hi all,

Looking through the blk-mq code I tried to figure out if and how the
driver is supposed to set any interrupt affinity when block-mq is
enabled.

Thing is, for your typical driver you would set the interrupt
affinity during init time (eg for SCSI drivers during host_alloc).
But to set the interrupt affinity you'd need the cpumask, which is
only populated way later during queue setup.

So now I got two bad choices: either I have to delay setting the
interrupt affinity until after the queue is created, making things
awkward with several queues, or I have to out-guess the blk-mq
mapping algorithm and set the interrupt affinity prior to queue setup.

Tests with the lpfc driver found that one absolutely _does_ want to
do irq affinity; not doing so limits the performance to single-queue
results.

So what is the expected strategy here?
Or am I just too stupid to find it?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

                 reply	other threads:[~2016-01-29  9:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56AB338B.4020804@suse.de \
    --to=hare@suse.de \
    --cc=Linux-scsi@vger.kernel.org \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.