From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 4/5] mm: Use radix_tree_iter_retry() To: Matthew Wilcox , Andrew Morton , Hugh Dickins References: <1453929472-25566-1-git-send-email-matthew.r.wilcox@intel.com> <1453929472-25566-5-git-send-email-matthew.r.wilcox@intel.com> Cc: Matthew Wilcox , Konstantin Khlebnikov , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org From: Vlastimil Babka Message-ID: <56AB7B27.3090805@suse.cz> Date: Fri, 29 Jan 2016 15:45:59 +0100 MIME-Version: 1.0 In-Reply-To: <1453929472-25566-5-git-send-email-matthew.r.wilcox@intel.com> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: On 01/27/2016 10:17 PM, Matthew Wilcox wrote: > From: Matthew Wilcox > > Instead of a 'goto restart', we can now use radix_tree_iter_retry() > to restart from our current position. This will make a difference > when there are more ways to happen across an indirect pointer. And it > eliminates some confusing gotos. > > Signed-off-by: Matthew Wilcox [...] > diff --git a/mm/shmem.c b/mm/shmem.c > index fa2ceb2d2655..6ec14b70d82d 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -388,8 +388,10 @@ restart: > * don't need to reset the counter, nor do we risk infinite > * restarts. > */ > - if (radix_tree_deref_retry(page)) > - goto restart; > + if (radix_tree_deref_retry(page)) { > + slot = radix_tree_iter_retry(&iter); > + continue; > + } > > if (radix_tree_exceptional_entry(page)) > swapped++; This should be applied on top. There are no restarts anymore. ----8<---- >>From 3b0bdd370b57fb6d83b213e140cd1fb0e8962af8 Mon Sep 17 00:00:00 2001 From: Vlastimil Babka Date: Fri, 29 Jan 2016 15:41:31 +0100 Subject: [PATCH] mm: Use radix_tree_iter_retry()-fix Remove now-obsolete-and-misleading comment. Signed-off-by: Vlastimil Babka --- mm/shmem.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 8f89abd4eaee..4d758938340c 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -382,11 +382,6 @@ unsigned long shmem_partial_swap_usage(struct address_space *mapping, page = radix_tree_deref_slot(slot); - /* - * This should only be possible to happen at index 0, so we - * don't need to reset the counter, nor do we risk infinite - * restarts. - */ if (radix_tree_deref_retry(page)) { slot = radix_tree_iter_retry(&iter); continue; -- 2.7.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by kanga.kvack.org (Postfix) with ESMTP id A0CE26B0253 for ; Fri, 29 Jan 2016 09:46:02 -0500 (EST) Received: by mail-wm0-f53.google.com with SMTP id l66so57534448wml.0 for ; Fri, 29 Jan 2016 06:46:02 -0800 (PST) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id it4si22516894wjb.239.2016.01.29.06.46.01 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Jan 2016 06:46:01 -0800 (PST) Subject: Re: [PATCH 4/5] mm: Use radix_tree_iter_retry() References: <1453929472-25566-1-git-send-email-matthew.r.wilcox@intel.com> <1453929472-25566-5-git-send-email-matthew.r.wilcox@intel.com> From: Vlastimil Babka Message-ID: <56AB7B27.3090805@suse.cz> Date: Fri, 29 Jan 2016 15:45:59 +0100 MIME-Version: 1.0 In-Reply-To: <1453929472-25566-5-git-send-email-matthew.r.wilcox@intel.com> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Matthew Wilcox , Andrew Morton , Hugh Dickins Cc: Matthew Wilcox , Konstantin Khlebnikov , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org On 01/27/2016 10:17 PM, Matthew Wilcox wrote: > From: Matthew Wilcox > > Instead of a 'goto restart', we can now use radix_tree_iter_retry() > to restart from our current position. This will make a difference > when there are more ways to happen across an indirect pointer. And it > eliminates some confusing gotos. > > Signed-off-by: Matthew Wilcox [...] > diff --git a/mm/shmem.c b/mm/shmem.c > index fa2ceb2d2655..6ec14b70d82d 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -388,8 +388,10 @@ restart: > * don't need to reset the counter, nor do we risk infinite > * restarts. > */ > - if (radix_tree_deref_retry(page)) > - goto restart; > + if (radix_tree_deref_retry(page)) { > + slot = radix_tree_iter_retry(&iter); > + continue; > + } > > if (radix_tree_exceptional_entry(page)) > swapped++; This should be applied on top. There are no restarts anymore. ----8<---- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756412AbcA2OqF (ORCPT ); Fri, 29 Jan 2016 09:46:05 -0500 Received: from mx2.suse.de ([195.135.220.15]:36567 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756389AbcA2OqC (ORCPT ); Fri, 29 Jan 2016 09:46:02 -0500 Subject: Re: [PATCH 4/5] mm: Use radix_tree_iter_retry() To: Matthew Wilcox , Andrew Morton , Hugh Dickins References: <1453929472-25566-1-git-send-email-matthew.r.wilcox@intel.com> <1453929472-25566-5-git-send-email-matthew.r.wilcox@intel.com> Cc: Matthew Wilcox , Konstantin Khlebnikov , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org From: Vlastimil Babka Message-ID: <56AB7B27.3090805@suse.cz> Date: Fri, 29 Jan 2016 15:45:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1453929472-25566-5-git-send-email-matthew.r.wilcox@intel.com> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/27/2016 10:17 PM, Matthew Wilcox wrote: > From: Matthew Wilcox > > Instead of a 'goto restart', we can now use radix_tree_iter_retry() > to restart from our current position. This will make a difference > when there are more ways to happen across an indirect pointer. And it > eliminates some confusing gotos. > > Signed-off-by: Matthew Wilcox [...] > diff --git a/mm/shmem.c b/mm/shmem.c > index fa2ceb2d2655..6ec14b70d82d 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -388,8 +388,10 @@ restart: > * don't need to reset the counter, nor do we risk infinite > * restarts. > */ > - if (radix_tree_deref_retry(page)) > - goto restart; > + if (radix_tree_deref_retry(page)) { > + slot = radix_tree_iter_retry(&iter); > + continue; > + } > > if (radix_tree_exceptional_entry(page)) > swapped++; This should be applied on top. There are no restarts anymore. ----8<---- >>From 3b0bdd370b57fb6d83b213e140cd1fb0e8962af8 Mon Sep 17 00:00:00 2001 From: Vlastimil Babka Date: Fri, 29 Jan 2016 15:41:31 +0100 Subject: [PATCH] mm: Use radix_tree_iter_retry()-fix Remove now-obsolete-and-misleading comment. Signed-off-by: Vlastimil Babka --- mm/shmem.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 8f89abd4eaee..4d758938340c 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -382,11 +382,6 @@ unsigned long shmem_partial_swap_usage(struct address_space *mapping, page = radix_tree_deref_slot(slot); - /* - * This should only be possible to happen at index 0, so we - * don't need to reset the counter, nor do we risk infinite - * restarts. - */ if (radix_tree_deref_retry(page)) { slot = radix_tree_iter_retry(&iter); continue; -- 2.7.0