From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932343AbcA2PYR (ORCPT ); Fri, 29 Jan 2016 10:24:17 -0500 Received: from s12p02o147.mxlogic.net ([208.65.145.70]:42929 "EHLO s12p02o147.mxlogic.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752311AbcA2PYQ convert rfc822-to-8bit (ORCPT ); Fri, 29 Jan 2016 10:24:16 -0500 X-Greylist: delayed 549 seconds by postgrey-1.27 at vger.kernel.org; Fri, 29 Jan 2016 10:24:16 EST X-MXL-Hash: 56ab842056be8919-5f434d96ec0c2e0cf4a04c54d77d5f476f8f7191 X-MXL-Hash: 56ab81fa7ccc95ba-723752984d548b7072f08bed5c9c175c54387c19 From: Kevin Smith To: Andrew Lunn , Vivien Didelot CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel@savoirfairelinux.com" , "David S. Miller" , Russell King Subject: Re: [PATCH net] net: dsa: mv88e6xxx: fix port VLAN maps Thread-Topic: [PATCH net] net: dsa: mv88e6xxx: fix port VLAN maps Thread-Index: AQHRWhaXW3eQkTPA/kqF18FvP5Ch058SJxoAgADY8gA= Date: Fri, 29 Jan 2016 15:14:59 +0000 Message-ID: <56AB81F4.6050409@elecsyscorp.com> References: <1454018077-11222-1-git-send-email-vivien.didelot@savoirfairelinux.com> <20160129021832.GA12692@lunn.ch> In-Reply-To: <20160129021832.GA12692@lunn.ch> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.63.192.165] Content-Type: text/plain; charset="Windows-1252" Content-ID: <1AD3B5D749F08E4B9566AE85D7217024@dciincorporated.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-AnalysisOut: [v=2.1 cv=d8HzvEXE c=1 sm=1 tr=0 a=51qEjsKpZkmECDgIwGerrA==] X-AnalysisOut: [:117 a=51qEjsKpZkmECDgIwGerrA==:17 a=HdYs5F2daWEA:10 a=N65] X-AnalysisOut: [9UExz7-8A:10 a=xqWC_Br6kY4A:10 a=7aQ_Q-yQQ-AA:10 a=LfzEU8a] X-AnalysisOut: [ZAAAA:8 a=aRxQL1JOAAAA:8 a=RQEgUvxuHf6yDt-tLOIA:9 a=pILNOx] X-AnalysisOut: [qGKmIA:10] X-Spam: [F=0.5000000000; CM=0.500; MH=0.500(2016012914); S=0.413(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [64.198.156.98] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/28/2016 08:18 PM, Andrew Lunn wrote: > On Thu, Jan 28, 2016 at 04:54:37PM -0500, Vivien Didelot wrote: >> Currently the port based VLAN maps should be configured to allow every >> port to egress frames on all other ports, except themselves. >> >> The debugfs interface shows that they are misconfigured. For instance, a >> 7-port switch has the following content in the related register 0x06: >> >> GLOBAL GLOBAL2 SERDES 0 1 2 3 4 5 6 >> ... >> 6: 1fa4 1f0f 4 7f 7e 7d 7c 7b 7a 79 >> ... >> >> This means that port 3 is allowed to talk to port 2-6, but cannot talk >> to ports 0 and 1. With this fix, port 3 can correctly talk to all ports >> except 3 itself: >> >> GLOBAL GLOBAL2 SERDES 0 1 2 3 4 5 6 >> ... >> 6: 1fa4 1f0f 4 7e 7d 7b 77 6f 5f 3f >> ... >> >> Fixes: ede8098d0fef ("net: dsa: mv88e6xxx: bridges do not need an FID") >> Reported-by: Kevin Smith >> Signed-off-by: Vivien Didelot > Reviewed-by: Andrew Lunn Tested-by: Kevin Smith