From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-watchdog-owner@vger.kernel.org>
Received: from bh-25.webhostbox.net ([208.91.199.152]:34239 "EHLO
	bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756256AbcA2PXK (ORCPT
	<rfc822;linux-watchdog@vger.kernel.org>);
	Fri, 29 Jan 2016 10:23:10 -0500
Subject: Re: [PATCH v6] Add sun4v_wdt watchdog driver
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>,
	Wim Coekaerts <wim.coekaerts@oracle.com>, wim@iguana.be
References: <1454017572-5235-1-git-send-email-wim.coekaerts@oracle.com>
 <56AB816B.6030900@oracle.com>
Cc: linux-watchdog@vger.kernel.org, sparclinux@vger.kernel.org
From: Guenter Roeck <linux@roeck-us.net>
Message-ID: <56AB83DA.1020505@roeck-us.net>
Date: Fri, 29 Jan 2016 07:23:06 -0800
MIME-Version: 1.0
In-Reply-To: <56AB816B.6030900@oracle.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-watchdog-owner@vger.kernel.org
List-Id: linux-watchdog@vger.kernel.org

On 01/29/2016 07:12 AM, Stanislav Kholmanskikh wrote:
>
>
> On 01/29/2016 12:46 AM, Wim Coekaerts wrote:
> <cut>
>> +static const struct watchdog_info sun4v_wdt_ident = {
>> +    .options =    WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE,
>> +    .identity =    "sun4v hypervisor watchdog",
>> +    .firmware_version = 0,
>> +};
>
> In accordance to watchdog_ioctl() in drivers/watchdog/watchdog_dev.c WDIOF_KEEPALIVEPING may be needed here as to enable the support of WDIOC_KEEPALIVE ioctl.
>
> Correct? So maybe add it then?
>
Yes. Not having the flag means that the ioctl is not supported,
and that keepalives have to be implemented using file i/o.

Wim, oversight or on purpose ?

Thanks,
Guenter

> Thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


From mboxrd@z Thu Jan  1 00:00:00 1970
From: Guenter Roeck <linux@roeck-us.net>
Date: Fri, 29 Jan 2016 15:23:06 +0000
Subject: Re: [PATCH v6] Add sun4v_wdt watchdog driver
Message-Id: <56AB83DA.1020505@roeck-us.net>
List-Id: <sparclinux.vger.kernel.org>
References: <1454017572-5235-1-git-send-email-wim.coekaerts@oracle.com>
 <56AB816B.6030900@oracle.com>
In-Reply-To: <56AB816B.6030900@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>, Wim Coekaerts <wim.coekaerts@oracle.com>, wim@iguana.be
Cc: linux-watchdog@vger.kernel.org, sparclinux@vger.kernel.org

On 01/29/2016 07:12 AM, Stanislav Kholmanskikh wrote:
>
>
> On 01/29/2016 12:46 AM, Wim Coekaerts wrote:
> <cut>
>> +static const struct watchdog_info sun4v_wdt_ident = {
>> +    .options =    WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE,
>> +    .identity =    "sun4v hypervisor watchdog",
>> +    .firmware_version = 0,
>> +};
>
> In accordance to watchdog_ioctl() in drivers/watchdog/watchdog_dev.c WDIOF_KEEPALIVEPING may be needed here as to enable the support of WDIOC_KEEPALIVE ioctl.
>
> Correct? So maybe add it then?
>
Yes. Not having the flag means that the ioctl is not supported,
and that keepalives have to be implemented using file i/o.

Wim, oversight or on purpose ?

Thanks,
Guenter

> Thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>