From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlastimil Babka Subject: Re: Build failures (s390) in -next due to 'mm, printk: introduce new format string for flags' Date: Fri, 29 Jan 2016 16:40:46 +0100 Message-ID: <56AB87FE.8010800@suse.cz> References: <56AB86BA.8020507@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:33890 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932254AbcA2Pks (ORCPT ); Fri, 29 Jan 2016 10:40:48 -0500 In-Reply-To: <56AB86BA.8020507@roeck-us.net> Sender: linux-next-owner@vger.kernel.org List-ID: To: Guenter Roeck , "linux-next@vger.kernel.org" Cc: Michal Hocko , Andrew Morton , linux-s390 , Heiko Carstens On 01/29/2016 04:35 PM, Guenter Roeck wrote: > Hi, > > s390 builds in -next fail with lots of errors such as: > > include/linux/jump_label.h: In function 'static_key_count': > include/linux/jump_label.h:122:2: error: implicit declaration of function 'atomic_read' [-Werror=implicit-function-declaration] > return atomic_read(&key->enabled); > ... > ./arch/s390/include/asm/atomic.h: At top level: > ./arch/s390/include/asm/atomic.h:74:19: error: static declaration of 'atomic_read' follows non-static declaration > static inline int atomic_read(const atomic_t *v) > > As far as I can see this is due to recursive inclusion of linux/atomic.h > (which in turn is triggered by recursive inclusion of linux/mmdebug.h). > > I was able to "fix" the problem by removing the inclusion of mmdebug.h from > arch/s390/include/asm/cmpxchg.h. That is not a proper fix, though, since the file > uses VM_BUG_ON(), which is defined in mmdebug.h. > > The problem was introduced with 'mm, printk: introduce new format string for flags'. Yeah sorry about that, I sent a fixed fix: http://marc.info/?l=linux-mm&m=145406672221395&w=2