From: Tomas Henzl <thenzl@redhat.com>
To: Sumit Saxena <sumit.saxena@avagotech.com>,
jbottomley@parallels.com, hch@infradead.org,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, kashyap.desai@avagotech.com
Subject: Re: [PATCH v2 11/15] megaraid_sas: Make adprecovery variable atomic
Date: Fri, 29 Jan 2016 16:52:48 +0100 [thread overview]
Message-ID: <56AB8AD0.1060203@redhat.com> (raw)
In-Reply-To: <1453995276-24955-12-git-send-email-sumit.saxena@avagotech.com>
On 28.1.2016 16:34, Sumit Saxena wrote:
> Make instance->adprecovery variable atomic and removes hba_lock spinlock while accessing instance->adprecovery.
>
> Tomas commented on last time sent patch asking to use u8 instead of atomic for adprecovery. I agree that atomic_t is not required
> here but this is done for not to touch legacy code of MFI adapters and replace hba_lock with atomic_t so there are no changes
> in this patch on top of last time sent patch.
The way how both, the atomic variable now and the hba_lock we had before, work
is not equal - the sw will now behave differently, so you can't replace it
and expect nothing would change
The protection they provide was/is weak anyway, I think that it does not
protect you from anything.
btw. you forgot to remove the hba_lock in megasas_complete_cmd_dpc_fusion
OK, old code, you don't want to touch/test, and the maintainer has accepted it
so I accept it too.
--tm
next prev parent reply other threads:[~2016-01-29 15:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 15:34 [PATCH v2 00/15] megaraid_sas: Updates for scsi-next Sumit Saxena
2016-01-28 15:34 ` [PATCH v2 01/15] megaraid_sas: Do not allow PCI access during OCR Sumit Saxena
2016-01-28 15:34 ` [PATCH v2 02/15] megaraid_sas: MFI IO timeout handling Sumit Saxena
2016-01-28 15:34 ` [PATCH v2 03/15] megaraid_sas: Syncing request flags macro names with firmware Sumit Saxena
2016-01-28 15:34 ` [PATCH v2 04/15] megaraid_sas: Task management support Sumit Saxena
2016-01-28 15:34 ` [PATCH v2 05/15] megaraid_sas: Update device Queue depth based on interface type Sumit Saxena
2016-01-28 15:34 ` [PATCH v2 06/15] megaraid_sas: Fastpath region lock bypass Sumit Saxena
2016-01-28 15:34 ` [PATCH v2 07/15] megaraid_sas: Reply Descriptor Post Queue(RDPQ) support Sumit Saxena
2016-01-29 15:19 ` Tomas Henzl
2016-01-28 15:34 ` [PATCH v2 08/15] megaraid_sas: Code optimization build_and_issue_cmd return-type Sumit Saxena
2016-01-28 15:34 ` [PATCH v2 09/15] megaraid_sas: Dual Queue depth support Sumit Saxena
2016-01-28 15:34 ` [PATCH v2 10/15] megaraid_sas: IO throttling support Sumit Saxena
2016-01-28 15:34 ` [PATCH v2 11/15] megaraid_sas: Make adprecovery variable atomic Sumit Saxena
2016-01-29 15:52 ` Tomas Henzl [this message]
2016-01-28 15:34 ` [PATCH v2 12/15] megaraid_sas: MFI adapter's OCR changes Sumit Saxena
2016-01-28 15:34 ` [PATCH v2 13/15] megaraid_sas: Introduce module parameter for SCSI command-timeout Sumit Saxena
2016-01-28 15:34 ` [PATCH v2 14/15] megaraid_sas: SPERC OCR changes Sumit Saxena
2016-01-28 15:34 ` [PATCH v2 15/15] megaraid_sas: driver version upgrade Sumit Saxena
2016-01-29 2:54 ` [PATCH v2 00/15] megaraid_sas: Updates for scsi-next Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AB8AD0.1060203@redhat.com \
--to=thenzl@redhat.com \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sumit.saxena@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.