From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lists.s-osg.org ([54.187.51.154]:34860 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932963AbcA2SWZ (ORCPT ); Fri, 29 Jan 2016 13:22:25 -0500 Subject: Re: [PATCH 11/13] [media] tvp5150: identify it as a MEDIA_ENT_F_ATV_DECODER To: Mauro Carvalho Chehab References: Cc: Linux Media Mailing List , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Guennadi Liakhovetski , Eduard Gavin From: Javier Martinez Canillas Message-ID: <56ABADDB.4080701@osg.samsung.com> Date: Fri, 29 Jan 2016 15:22:19 -0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hello Mauro, On 01/29/2016 09:11 AM, Mauro Carvalho Chehab wrote: > The tvp5150 is an analog TV decoder. Identify as such at > the media graph, or otherwise devices using it would fail. > > That avoids the following warning: > [ 1546.669139] usb 2-3.3: Entity type for entity tvp5150 5-005c was not initialized! > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/i2c/tvp5150.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c > index 20428f052506..19b52736b24e 100644 > --- a/drivers/media/i2c/tvp5150.c > +++ b/drivers/media/i2c/tvp5150.c > @@ -1319,6 +1319,9 @@ static int tvp5150_probe(struct i2c_client *c, > core->pads[DEMOD_PAD_IF_INPUT].flags = MEDIA_PAD_FL_SINK; > core->pads[DEMOD_PAD_VID_OUT].flags = MEDIA_PAD_FL_SOURCE; > core->pads[DEMOD_PAD_VBI_OUT].flags = MEDIA_PAD_FL_SOURCE; > + > + sd->entity.function = MEDIA_ENT_F_ATV_DECODER; > + > res = media_entity_pads_init(&sd->entity, DEMOD_NUM_PADS, core->pads); > if (res < 0) > return res; > Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America