From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPFiK-0005gv-QM for qemu-devel@nongnu.org; Fri, 29 Jan 2016 15:32:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aPFiJ-0000dZ-Sf for qemu-devel@nongnu.org; Fri, 29 Jan 2016 15:32:16 -0500 References: <1454096953-31773-1-git-send-email-mreitz@redhat.com> <1454096953-31773-3-git-send-email-mreitz@redhat.com> From: Eric Blake Message-ID: <56ABCC48.3060308@redhat.com> Date: Fri, 29 Jan 2016 13:32:08 -0700 MIME-Version: 1.0 In-Reply-To: <1454096953-31773-3-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pdOQ6REnRevBe4ekTj9va2jtq45cqRp0W" Subject: Re: [Qemu-devel] [PATCH v4 2/4] blockdev: Fix 'change' for slot devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , John Snow , Alberto Garcia , qemu-stable , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pdOQ6REnRevBe4ekTj9va2jtq45cqRp0W Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/29/2016 12:49 PM, Max Reitz wrote: > 'change' and related operations did not work when used on guest devices= > featuring removable media but no actual tray, because > blk_dev_is_tray_open() always returned false for them and the > blockdev-{insert,remove}-medium commands required it to return true. >=20 > Fix this by making blockdev-{insert,remove}-medium work on tray-less > devices. Also, blockdev-{open,close}-tray are now explicitly no-ops whe= n > invoked on such devices, and blk_dev_change_media_cb() is instead > called by blockdev-{insert,remove}-medium (for tray-less devices only).= >=20 > Reported-by: Peter Maydell > Cc: qemu-stable > Signed-off-by: Max Reitz > Reviewed-by: Alberto Garcia > --- > blockdev.c | 31 +++++++++++++++++++++++++++++-- > qapi/block-core.json | 3 +-- > 2 files changed, 30 insertions(+), 4 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --pdOQ6REnRevBe4ekTj9va2jtq45cqRp0W Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWq8xIAAoJEKeha0olJ0Nq4nwH/3Qj6/avzWV6/YeTGrGnvKys oxpeYN5c7xcF2duX/hCso4GLC7BXSZnbA9yHBvbRM2a/zTf5XRyUWeT7IMLQqeXL Z0l7hxGYGbGsOQyeGzHwwWPziCpgDaeUUT5xF8wZ7WJa+uaD9s/O+rQ6kC3FXDCb B+0l6iWK5r2zCGO9ipsdETHyURnqRv5tq5CZ+I8dt+hiiarp2HhCN/e/y6sC/kfl iCNfemVJ6SmxkMriE/4zSIyrUKYlItIv7ALyUolzZK/GbwncfqTVnkjuCE5lF73J ba9BqTaEU/etHKGZddWfWQmLBpfBE+yuSMsKfQjUWyxdKGy0l7oYmRAO4NYbsQc= =fL8I -----END PGP SIGNATURE----- --pdOQ6REnRevBe4ekTj9va2jtq45cqRp0W--