From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPFjY-0006fm-1t for qemu-devel@nongnu.org; Fri, 29 Jan 2016 15:33:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aPFjX-000122-3X for qemu-devel@nongnu.org; Fri, 29 Jan 2016 15:33:31 -0500 References: <1454096953-31773-1-git-send-email-mreitz@redhat.com> <1454096953-31773-4-git-send-email-mreitz@redhat.com> From: Eric Blake Message-ID: <56ABCC95.4040507@redhat.com> Date: Fri, 29 Jan 2016 13:33:25 -0700 MIME-Version: 1.0 In-Reply-To: <1454096953-31773-4-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Cl9Ng31gtq8IisqieTl4N7aHXMamSkfu1" Subject: Re: [Qemu-devel] [PATCH v4 3/4] Revert "hw/block/fdc: Implement tray status" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , John Snow , Alberto Garcia , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Cl9Ng31gtq8IisqieTl4N7aHXMamSkfu1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/29/2016 12:49 PM, Max Reitz wrote: > This reverts the changes that commit > 2e1280e8ff95b3145bc6262accc9d447718e5318 applied to hw/block/fdc.c; > also, an additional case of drv->media_inserted use has crept in since,= > which is replaced by a call to blk_is_inserted(). >=20 > That commit changed tests/fdc-test.c, too, because after it, one less > TRAY_MOVED event would be emitted when executing 'change' on an empty > drive. However, now, no TRAY_MOVED events will be emitted at all, and > the tray_open status returned by query-block will always be false, > necessitating (different) changes to tests/fdc-test.c and iotest 118, > which is why this patch is not a pure revert of said commit. >=20 > Signed-off-by: Max Reitz > --- > hw/block/fdc.c | 23 +++------- > tests/fdc-test.c | 2 - > tests/qemu-iotests/118 | 117 +++++++++++++++--------------------------= -------- > 3 files changed, 43 insertions(+), 99 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Cl9Ng31gtq8IisqieTl4N7aHXMamSkfu1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWq8yVAAoJEKeha0olJ0NqB8sH/idqxgsJnnEH5ryK4tzjqagP GfrrtIHxneETMKbTaW66iS30zhIbWUN/lacYEsh0ZDczzHocRQUZ0lucm1i6c8Ww hDhAoWSu8MWCOhPK/3cViv2NW2bA9lKTU9Uv9USlmNmtdOewiip7aSdWGi3vqasD rDf/rldTDfUtty6M5p8S1ItSGaFyQoGSkes6AlwIdThC6iI2WcPTti7QHZI8AAiy REnjV/aPDh2Ck2QDDEHdTojVvm5qWQOpWSD4ZaDDf6WXXe2ngtZOYY6VzBM/qqVG tgM3Z/HLfUGWHf4GbPTY0ZJji/0MvUqs7BwMtSVETXrxeEPVRA7tmFKNtGiHHcw= =zWCn -----END PGP SIGNATURE----- --Cl9Ng31gtq8IisqieTl4N7aHXMamSkfu1--