From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] x86: Convert shadow-paging to Kconfig Date: Fri, 29 Jan 2016 15:46:54 -0600 Message-ID: <56ABDDCE.6020005@cardoe.com> References: <1454091618-13423-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2430435151398127630==" Return-path: In-Reply-To: <1454091618-13423-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , Xen-devel Cc: George Dunlap , Tim Deegan , Jan Beulich List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============2430435151398127630== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SXv9pQaSOC0A00V9kFU8USDDNllmE3DNF" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SXv9pQaSOC0A00V9kFU8USDDNllmE3DNF Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 1/29/16 12:20 PM, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Doug Goldstein > CC: Tim Deegan > CC: George Dunlap >=20 > v2: > * Expand text. Use more-common makefile syntax > --- > xen/arch/x86/Kconfig | 18 ++++++++++++++++++ > xen/arch/x86/Rules.mk | 4 ---- > xen/arch/x86/mm/shadow/Makefile | 2 +- > 3 files changed, 19 insertions(+), 5 deletions(-) >=20 > diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig > index 4781b34..1fd72fa 100644 > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -27,6 +27,24 @@ menu "Architecture Features" > =20 > source "arch/Kconfig" > =20 > +config SHADOW_PAGING > + bool "Shadow Paging" > + default y > + ---help--- > + > + Shadow paging is a software alternative to hardware paging s= upport > + (Intel EPT, AMD NPT). > + > + It is required for: > + * Running HVM guests on hardware lacking hardware paging s= upport > + (First-generation Intel VT-x or AMD SVM). > + * Live migration of PV guests. > + > + Under a small number of specific workloads, shadow paging ma= y be > + deliberately used as a performance optimisation. > + > + If unsure, say Y. > + > config BIGMEM > bool "big memory support" > default n > diff --git a/xen/arch/x86/Rules.mk b/xen/arch/x86/Rules.mk > index a108d24..a1cdae0 100644 > --- a/xen/arch/x86/Rules.mk > +++ b/xen/arch/x86/Rules.mk > @@ -22,13 +22,9 @@ $(call as-insn-check,CFLAGS,CC,".equ \"x\"$$(comma)1= ", \ > -U__OBJECT_LABEL__ -DHAVE_GAS_QUOTED_SYM \ > '-D__OBJECT_LABEL__=3D$(subst $(BASEDIR)/,,$(CURD= IR))/$$@') > =20 > -shadow-paging ?=3D y > - > CFLAGS +=3D -mno-red-zone -mno-sse -fpic > CFLAGS +=3D -fno-asynchronous-unwind-tables > # -fvisibility=3Dhidden reduces -fpic cost, if it's available > ifneq ($(call cc-option,$(CC),-fvisibility=3Dhidden,n),n) > CFLAGS +=3D -DGCC_HAS_VISIBILITY_ATTRIBUTE > endif > - > -CFLAGS-$(shadow-paging) +=3D -DCONFIG_SHADOW_PAGING > diff --git a/xen/arch/x86/mm/shadow/Makefile b/xen/arch/x86/mm/shadow/M= akefile > index a07bc0c..cd4ec8a 100644 > --- a/xen/arch/x86/mm/shadow/Makefile > +++ b/xen/arch/x86/mm/shadow/Makefile > @@ -1,4 +1,4 @@ > -ifeq ($(shadow-paging),y) > +ifeq ($(CONFIG_SHADOW_PAGING),y) > obj-y +=3D common.o guest_2.o guest_3.o guest_4.o > else > obj-y +=3D none.o >=20 Reviewed-by: Doug Goldstein --=20 Doug Goldstein --SXv9pQaSOC0A00V9kFU8USDDNllmE3DNF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWq93RXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUGUAP/1keJ18wbOWR25tjMZTtSs4o 0fgDtOcF4XDx+IlCInXq/fcr3u3Wptv1x1psEUGr5Br+Pmsgm3f3Zuu0waUXIGOp mmoe7E3fpa5lEskbk4HX5bB0ZeNkpVKX4o5d7j0+MCzwklTKFBTyORkRzQXyHzYQ vEQ6993Xa4gjuAEl9+P7JZtAus4dHdCKdqBnAUeRND+o5Tq28RBYyHutfEYETDrt 7E22tmGbO/W+Zjw9ZQVaLJm8XwcvsGtU94nqkQyL7sWfscaX5RJt89UIbyxdfvcu B3rK4n1rnzkM1tN7rqFrQcwHif3uzXefKOS1dAX+hdKaTacbz/JQ8R/dQ7F7yXY8 m/Eq8tz+0s+4+cZSv1YTynjsQMr3OPo8iuyUoSbUX7/wAG94vzTuSJFXvzf9QrO6 PJGozayavCqbB36QAaMD3Ey5mxfCcq7uOyr305qwCD0JdQ7U9vdklI50krEm4LjM /9qx0UI3UEJFFWVO/K+WA2LGKoBsKKFq8MjZJV0ciYaB/vrKNbtjmCC9yGXWAYog yEqdpZM+eXzhTtvpW//iWx/Acg5SkrxlpLRvgwg7PcCNaHrmfs7rOreC/ReEWhgI yJRwtSQqQEZaQBNUs2qdtI4chtGzpHJq5du1SH0maUYfPF1+B60Oss9HVozZVm6O qocAUUp5oBcnUYDLFaiX =5kZY -----END PGP SIGNATURE----- --SXv9pQaSOC0A00V9kFU8USDDNllmE3DNF-- --===============2430435151398127630== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2430435151398127630==--