All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Alex Estrin <alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH v2 03/22] IB/srpt: Inline srpt_sdev_name()
Date: Fri, 29 Jan 2016 15:12:04 -0800	[thread overview]
Message-ID: <56ABF1C4.3090106@sandisk.com> (raw)
In-Reply-To: <56ABF16E.7070006-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>

srpt_sdev_name() is too trivial to keep it as a separate function.
Hence inline this function.

Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Reviewed-by: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 drivers/infiniband/ulp/srpt/ib_srpt.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index fde32ed..0194624 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -109,16 +109,6 @@ enum dma_data_direction opposite_dma_dir(enum dma_data_direction dir)
 	}
 }
 
-/**
- * srpt_sdev_name() - Return the name associated with the HCA.
- *
- * Examples are ib0, ib1, ...
- */
-static inline const char *srpt_sdev_name(struct srpt_device *sdev)
-{
-	return sdev->device->name;
-}
-
 static enum rdma_ch_state srpt_get_ch_state(struct srpt_rdma_ch *ch)
 {
 	unsigned long flags;
@@ -182,7 +172,7 @@ static void srpt_event_handler(struct ib_event_handler *handler,
 		return;
 
 	pr_debug("ASYNC event= %d on device= %s\n", event->event,
-		 srpt_sdev_name(sdev));
+		 sdev->device->name);
 
 	switch (event->event) {
 	case IB_EVENT_PORT_ERR:
@@ -3082,7 +3072,7 @@ static void srpt_add_one(struct ib_device *device)
 
 		if (srpt_refresh_port(sport)) {
 			pr_err("MAD registration failed for %s-%d.\n",
-			       srpt_sdev_name(sdev), i);
+			       sdev->device->name, i);
 			goto err_ring;
 		}
 		snprintf(sport->port_guid, sizeof(sport->port_guid),
-- 
2.7.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-01-29 23:12 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 23:10 [PATCH v2 00/22] IB/srpt patches for Linux kernel v4.6 Bart Van Assche
     [not found] ` <56ABF16E.7070006-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-29 23:11   ` [PATCH v2 01/22] IB/srpt: Add parentheses around sizeof argument Bart Van Assche
2016-01-29 23:11   ` [PATCH v2 02/22] IB/srpt: Remove struct srpt_node_acl Bart Van Assche
     [not found]     ` <56ABF1AF.3070301-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-02 10:57       ` Christoph Hellwig
2016-02-02 15:33       ` Estrin, Alex
2016-01-29 23:12   ` Bart Van Assche [this message]
2016-01-29 23:12   ` [PATCH v2 04/22] IB/srpt: Inline srpt_get_ch_state() Bart Van Assche
2016-01-29 23:12   ` [PATCH v2 05/22] IB/srpt: Introduce target_reverse_dma_direction() Bart Van Assche
2016-01-29 23:13   ` [PATCH v2 06/22] IB/srpt: Use scsilun_to_int() Bart Van Assche
2016-01-29 23:13   ` [PATCH v2 07/22] IB/srpt: Simplify srpt_handle_tsk_mgmt() Bart Van Assche
     [not found]     ` <56ABF21C.5070409-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-02 10:59       ` Christoph Hellwig
2016-01-29 23:13   ` [PATCH v2 08/22] IB/srpt: Simplify channel state management Bart Van Assche
2016-01-29 23:14   ` [PATCH v2 09/22] IB/srpt: Simplify srpt_shutdown_session() Bart Van Assche
2016-01-29 23:14   ` [PATCH v2 10/22] IB/srpt: Do not complain about initiator names without leading "0x" Bart Van Assche
     [not found]     ` <56ABF26F.4010509-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-30  1:57       ` Bart Van Assche
2016-02-02 11:00       ` Christoph Hellwig
2016-02-02 15:33       ` Estrin, Alex
2016-01-29 23:15   ` [PATCH v2 11/22] IB/srpt: Fix srpt_close_session() Bart Van Assche
2016-01-29 23:15   ` [PATCH v2 12/22] IB/srpt: Fix srpt_handle_cmd() error paths Bart Van Assche
     [not found]     ` <56ABF296.7040009-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-02 11:00       ` Christoph Hellwig
2016-02-02 15:34       ` Estrin, Alex
2016-01-29 23:15   ` [PATCH v2 13/22] IB/srpt: Fix how aborted commands are processed Bart Van Assche
     [not found]     ` <56ABF2A8.5060200-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-02 11:06       ` Christoph Hellwig
2016-02-02 15:34       ` Estrin, Alex
2016-01-29 23:16   ` [PATCH v2 14/22] IB/srpt: Inline trivial CM callback functions Bart Van Assche
     [not found]     ` <56ABF2BB.5060905-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-02 11:06       ` Christoph Hellwig
2016-02-02 15:34       ` Estrin, Alex
2016-01-29 23:16   ` [PATCH v2 15/22] IB/srpt: Eliminate srpt_find_channel() Bart Van Assche
     [not found]     ` <56ABF2CF.7040007-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-02 11:07       ` Christoph Hellwig
2016-01-29 23:17   ` [PATCH v2 16/22] IB/srpt: Log private data associated with REJ Bart Van Assche
     [not found]     ` <56ABF2ED.8020204-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-02 11:08       ` Christoph Hellwig
2016-01-29 23:17   ` [PATCH v2 17/22] IB/srpt: Convert rch_list to RCU Bart Van Assche
     [not found]     ` <56ABF301.8080105-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-02 11:12       ` Christoph Hellwig
2016-01-29 23:17   ` [PATCH v2 18/22] IB/srpt: Detect session shutdown reliably Bart Van Assche
2016-01-29 23:17   ` [PATCH v2 19/22] IB/srpt: Fix srpt_write_pending() Bart Van Assche
2016-01-29 23:18   ` [PATCH v2 20/22] IB/srpt: Log out all initiators if a port is disabled Bart Van Assche
     [not found]     ` <56ABF33C.9030509-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-02 11:13       ` Christoph Hellwig
2016-02-02 15:35       ` Estrin, Alex
2016-01-29 23:18   ` [PATCH v2 21/22] IB/srpt: Introduce srpt_process_wait_list() Bart Van Assche
     [not found]     ` <56ABF351.1040400-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-02 11:14       ` Christoph Hellwig
2016-02-02 15:36       ` Estrin, Alex
2016-01-29 23:19   ` [PATCH v2 22/22] IB/srpt: Fix wait list processing Bart Van Assche
     [not found]     ` <56ABF365.1020708-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-02 11:15       ` Christoph Hellwig
2016-02-02 15:37       ` Estrin, Alex

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56ABF1C4.3090106@sandisk.com \
    --to=bart.vanassche-xdaiopvojttbdgjk7y7tuq@public.gmane.org \
    --cc=alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.