From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPJCb-0006ea-RJ for qemu-devel@nongnu.org; Fri, 29 Jan 2016 19:15:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aPJCa-000856-R3 for qemu-devel@nongnu.org; Fri, 29 Jan 2016 19:15:45 -0500 References: <1454106932-17236-1-git-send-email-jsnow@redhat.com> From: Eric Blake Message-ID: <56AC00A9.50308@redhat.com> Date: Fri, 29 Jan 2016 17:15:37 -0700 MIME-Version: 1.0 In-Reply-To: <1454106932-17236-1-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wiReNUnMLw3LOtBWBFS4fJ5Dcx55j0d8Q" Subject: Re: [Qemu-devel] [PATCH] fdc: fix detection under Linux List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: pbonzini@redhat.com, hpoussin@reactos.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wiReNUnMLw3LOtBWBFS4fJ5Dcx55j0d8Q Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/29/2016 03:35 PM, John Snow wrote: > Accidentally, I removed a "feature" where empty drives had geometry > values applied to them, which allows seek on empty drives to work > "by accident," as QEMU actually tries to disallow that. >=20 > Seeks on empty drives should work, though, but the easiest thing is to > restore the misfeature where empty drives have non-zero geometries > applied. >=20 > Document the hack accordingly. >=20 > Signed-off-by: John Snow > --- > hw/block/fdc.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wiReNUnMLw3LOtBWBFS4fJ5Dcx55j0d8Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWrACpAAoJEKeha0olJ0NqGhAIAKbJ+bBngPD8wIFmIzPtaPgN UTehbWEuhLjLnyBZqCZPDdhlXGX1cbsP14gSpSPLYkHjwqyrw4BzQsg0Rm2B4l/q HfH+saThoWyBfeok87xXNuOhCNOQE/0eOZV9XvZH/Xho2sNzVDx5YmZ3ZOShCksd D6owJXTBK4q5LerkNbZnxV/qnKhDN9XJqU1sYJhCh3gXZLfo4MqXNpZ/xD/THQyc rgkjAddpE5AeNlgu0MbcmJkbHyC/3CwcqSCuMWdC/c/SrYS6hO3mNrvBtbPD8yTN vc2H+5yqBADcjvYPjZU5CHKeWaEAYhYV7chT7WNnpivwGFgHi7U2aHSLrweddvs= =cyad -----END PGP SIGNATURE----- --wiReNUnMLw3LOtBWBFS4fJ5Dcx55j0d8Q--