Re: [PATCH 1/5] iio: imu: inv-mpu6050: Fix interrupt pin configuration

[Jonathan Cameron <jic23@kernel.org>]

On 30/01/16 09:43, Adriana Reus wrote:
> The select/deselect_bypass duo writes the irq number into the interrupt
> configuration register.
> If there is a i2c slave device connected to the mpu (eg. a magnetometer)
> then this can hinder interrupt delivery for the accelerometer and
> gyroscope.
> Set this register to the default configuration.
> 
> Signed-off-by: Adriana Reus <adriana.reus@intel.com>
Hmm. I'd ideally like an invensense ack on this (and the series ideally!)
I'm not entirely clear what the original intent here was.

Jonathan
> ---
>  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 4 ++--
>  drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h  | 1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index f0e0609..5fe1dd8 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -129,7 +129,7 @@ static int inv_mpu6050_select_bypass(struct i2c_adapter *adap, void *mux_priv,
>  	if (!ret) {
>  		st->powerup_count++;
>  		ret = inv_mpu6050_write_reg_unlocked(st, st->reg->int_pin_cfg,
> -						     st->client->irq |
> +						     INV_MPU6050_INT_PIN_CFG |
>  						     INV_MPU6050_BIT_BYPASS_EN);
>  	}
>  write_error:
> @@ -147,7 +147,7 @@ static int inv_mpu6050_deselect_bypass(struct i2c_adapter *adap,
>  	mutex_lock(&indio_dev->mlock);
>  	/* It doesn't really mattter, if any of the calls fails */
>  	inv_mpu6050_write_reg_unlocked(st, st->reg->int_pin_cfg,
> -				       st->client->irq);
> +				       INV_MPU6050_INT_PIN_CFG);
>  	st->powerup_count--;
>  	if (!st->powerup_count)
>  		inv_mpu6050_write_reg_unlocked(st, st->reg->pwr_mgmt_1,
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h
> index db0a4a2..455b99d 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h
> @@ -185,6 +185,7 @@ struct inv_mpu6050_state {
>  
>  #define INV_MPU6050_REG_INT_PIN_CFG	0x37
>  #define INV_MPU6050_BIT_BYPASS_EN	0x2
> +#define INV_MPU6050_INT_PIN_CFG		0
>  
>  /* init parameters */
>  #define INV_MPU6050_INIT_FIFO_RATE           50
>