From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH v4 6/9] ASoC: rt5616: add mclk property for rt5616 document Date: Sun, 31 Jan 2016 17:09:51 +0800 Message-ID: <56ADCF5F.1010203@gmail.com> References: <1453970618-4383-1-git-send-email-wxt@rock-chips.com> <1453970618-4383-7-git-send-email-wxt@rock-chips.com> <20160129162800.GA10835@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160129162800.GA10835@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Rob Herring Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Pawel Moll , Ian Campbell , jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org, jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Heiko Stuebner , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mark Brown , keescook-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Kumar Gala , sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, leozwang-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, Caesar Wang List-Id: linux-rockchip.vger.kernel.org CuWcqCAyMDE25bm0MDHmnIgzMOaXpSAwMDoyOCwgUm9iIEhlcnJpbmcg5YaZ6YGTOgo+IE9uIFRo dSwgSmFuIDI4LCAyMDE2IGF0IDA0OjQzOjM1UE0gKzA4MDAsIENhZXNhciBXYW5nIHdyb3RlOgo+ PiBUaGlzIHBhdGNoIGFkZCB0aGUgbWNsayBwcm9wZXJ0eSBmb3IgdGhlIENPREVDIGRyaXZlciwK Pj4gc2luY2Ugc29tZXRpbWUgdGhlIENPREVDIGRyaXZlciBuZWVkcyB0aGUgY2xvY2sgZW5hYmxl ZC4KPiBzL2FkZC9hZGRzLwo+Cj4gcy9zb21ldGltZS9zb21ldGltZXMvCgpEb25lLCB0aGFua3Mg Zm9yIHBvaW50aW5nIG91dCB0aGF0LgoKCj4+IFRoZSBzeXN0ZW0gY2xvY2sgb2YgQUxDNTYxNiBj YW4gYmUgc2VsZWN0ZWQgZnJvbSBNQ0xLLAo+PiBUaGF0J3MgYWxzbyBtYWtlIGFzIHRoZSBjb2Rl YyBtYXN0ZXIgY2xvY2sgcHJvdmlkZXIsCj4gVGhhdCBhbHNvIG1ha2VzIHRoZSBjb2RlYyB0aGUg bWFzdGVyIGNsb2NrIHByb3ZpZGVyLgo+CgpEaXR0by4KCj4+IFNpZ25lZC1vZmYtYnk6IENhZXNh ciBXYW5nIDx3eHRAcm9jay1jaGlwcy5jb20+Cj4+Cj4+IC0tLQo+Pgo+PiBDaGFuZ2VzIGluIHY0 Ogo+PiAtIEFkZCB0aGlzIHBhdGNoIGluY2x1ZGVkIGluIGt5bGluIHNlcmllcyBwYXRjaGVzLgo+ Pgo+PiAgIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb3VuZC9ydDU2MTYudHh0 IHwgNiArKysrKysKPj4gICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspCj4+Cj4+IGRp ZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc291bmQvcnQ1NjE2 LnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb3VuZC9ydDU2MTYudHh0 Cj4+IGluZGV4IGVmYzQ4YzYuLmU0MTA4NTggMTAwNjQ0Cj4+IC0tLSBhL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9zb3VuZC9ydDU2MTYudHh0Cj4+ICsrKyBiL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb3VuZC9ydDU2MTYudHh0Cj4+IEBAIC04LDYgKzgsMTIg QEAgUmVxdWlyZWQgcHJvcGVydGllczoKPj4gICAKPj4gICAtIHJlZyA6IFRoZSBJMkMgYWRkcmVz cyBvZiB0aGUgZGV2aWNlLgo+PiAgIAo+PiArT3B0aW9uYWwgcHJvcGVydGllczoKPj4gKwo+PiAr LSBjbG9ja3M6IFRoZSBwaGFuZGxlIG9mIHRoZSBtYXN0ZXIgY2xvY2sgdG8gdGhlIENPREVDLgo+ PiArCj4+ICstIGNsb2NrLW5hbWVzOiBTaG91bGQgYmUgIm1jbGsiLgo+PiArCj4+ICAgUGlucyBv biB0aGUgZGV2aWNlIChmb3IgbGlua2luZyBpbnRvIGF1ZGlvIHJvdXRlcykgZm9yIFJUNTYxNjoK Pj4gICAKPj4gICAgICogSU4xUAo+PiAtLSAKPj4gMS45LjEKPj4KPiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IExpbnV4LXJvY2tjaGlwIG1haWxpbmcg bGlzdAo+IExpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCgoKLS0gClRoYW5r cywKQ2Flc2FyCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754232AbcAaJKQ (ORCPT ); Sun, 31 Jan 2016 04:10:16 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34504 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752284AbcAaJKB (ORCPT ); Sun, 31 Jan 2016 04:10:01 -0500 Subject: Re: [PATCH v4 6/9] ASoC: rt5616: add mclk property for rt5616 document To: Rob Herring References: <1453970618-4383-1-git-send-email-wxt@rock-chips.com> <1453970618-4383-7-git-send-email-wxt@rock-chips.com> <20160129162800.GA10835@rob-hp-laptop> Cc: Caesar Wang , Mark Rutland , devicetree@vger.kernel.org, hl@rock-chips.com, Pawel Moll , Ian Campbell , sonnyrao@chromium.org, jeffy.chen@rock-chips.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Mark Brown , keescook@google.com, cf@rock-chips.com, Kumar Gala , jay.xu@rock-chips.com, leozwang@google.com, Heiko Stuebner From: Caesar Wang Message-ID: <56ADCF5F.1010203@gmail.com> Date: Sun, 31 Jan 2016 17:09:51 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160129162800.GA10835@rob-hp-laptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016年01月30日 00:28, Rob Herring 写道: > On Thu, Jan 28, 2016 at 04:43:35PM +0800, Caesar Wang wrote: >> This patch add the mclk property for the CODEC driver, >> since sometime the CODEC driver needs the clock enabled. > s/add/adds/ > > s/sometime/sometimes/ Done, thanks for pointing out that. >> The system clock of ALC5616 can be selected from MCLK, >> That's also make as the codec master clock provider, > That also makes the codec the master clock provider. > Ditto. >> Signed-off-by: Caesar Wang >> >> --- >> >> Changes in v4: >> - Add this patch included in kylin series patches. >> >> Documentation/devicetree/bindings/sound/rt5616.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/rt5616.txt b/Documentation/devicetree/bindings/sound/rt5616.txt >> index efc48c6..e410858 100644 >> --- a/Documentation/devicetree/bindings/sound/rt5616.txt >> +++ b/Documentation/devicetree/bindings/sound/rt5616.txt >> @@ -8,6 +8,12 @@ Required properties: >> >> - reg : The I2C address of the device. >> >> +Optional properties: >> + >> +- clocks: The phandle of the master clock to the CODEC. >> + >> +- clock-names: Should be "mclk". >> + >> Pins on the device (for linking into audio routes) for RT5616: >> >> * IN1P >> -- >> 1.9.1 >> > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip -- Thanks, Caesar