From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQ4oU-0007A2-E6 for qemu-devel@nongnu.org; Sun, 31 Jan 2016 22:06:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQ4oP-0006HN-Dv for qemu-devel@nongnu.org; Sun, 31 Jan 2016 22:06:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35887) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQ4oP-0006HI-7w for qemu-devel@nongnu.org; Sun, 31 Jan 2016 22:05:57 -0500 References: <1453883380-10532-1-git-send-email-zhang.zhanghailiang@huawei.com> <1453883380-10532-3-git-send-email-zhang.zhanghailiang@huawei.com> From: Jason Wang Message-ID: <56AECB89.1080901@redhat.com> Date: Mon, 1 Feb 2016 11:05:45 +0800 MIME-Version: 1.0 In-Reply-To: <1453883380-10532-3-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v2 2/5] vl: Make object_create() public List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: Paolo Bonzini , zhangchen.fnst@cn.fujitsu.com, hongyang.yang@easystack.cn On 01/27/2016 04:29 PM, zhanghailiang wrote: > Make the helper object_create() public and fix its first > parameter to accept NULL value. Looks not very nice. Maybe pass a new predicate func for sanity check it better. > > Signed-off-by: zhanghailiang > Cc: Paolo Bonzini > --- > v2: > - New patch > --- > include/qemu-common.h | 2 ++ > vl.c | 4 ++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/qemu-common.h b/include/qemu-common.h > index 22b010c..52cf4fd 100644 > --- a/include/qemu-common.h > +++ b/include/qemu-common.h > @@ -500,4 +500,6 @@ int parse_debug_env(const char *name, int max, int initial); > const char *qemu_ether_ntoa(const MACAddr *mac); > void page_size_init(void); > > +int object_create(void *opaque, QemuOpts *opts, Error **errp); > + > #endif > diff --git a/vl.c b/vl.c > index f043009..b21335e 100644 > --- a/vl.c > +++ b/vl.c > @@ -2819,7 +2819,7 @@ static bool object_create_delayed(const char *type) > } > > > -static int object_create(void *opaque, QemuOpts *opts, Error **errp) > +int object_create(void *opaque, QemuOpts *opts, Error **errp) > { > Error *err = NULL; > char *type = NULL; > @@ -2842,7 +2842,7 @@ static int object_create(void *opaque, QemuOpts *opts, Error **errp) > if (err) { > goto out; > } > - if (!type_predicate(type)) { > + if (type_predicate && !type_predicate(type)) { > goto out; > } >