From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bmw-carit.de ([62.245.222.98]:43214 "EHLO mail.bmw-carit.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752731AbcBAGtc (ORCPT ); Mon, 1 Feb 2016 01:49:32 -0500 Subject: Re: [PATCH tip v6 2/5] kbuild: Add option to turn incompatible pointer check into error References: <1453992270-4688-1-git-send-email-daniel.wagner@bmw-carit.de> <1453992270-4688-3-git-send-email-daniel.wagner@bmw-carit.de> <56AB5867.6020405@bmw-carit.de> <20160129185523.GZ8889@windriver.com> From: Daniel Wagner Message-ID: <56AEFFF1.1010404@bmw-carit.de> Date: Mon, 1 Feb 2016 07:49:21 +0100 MIME-Version: 1.0 In-Reply-To: <20160129185523.GZ8889@windriver.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, linux-kbuild@vger.kernel.org, Marcelo Tosatti , Paolo Bonzini , "Paul E . McKenney" , Peter Zijlstra , Thomas Gleixner , Steven Rostedt , Boqun Feng On 01/29/2016 07:55 PM, Paul Gortmaker wrote: > [Re: [PATCH tip v6 2/5] kbuild: Add option to turn incompatible pointer check into error] On 29/01/2016 (Fri 13:17) Daniel Wagner wrote: > >> On 01/28/2016 03:44 PM, Daniel Wagner wrote: >>> +# enforce correct pointer usage >>> +KBUILD_CFLAGS += $(call cc-option,-Werror=incompatible-pointer-types) >>> + >> >> As it turns out there are a few fallouts by that one. I'll send fixes >> for it. > > Did you try non-x86 builds with this applied? I'd be really surprised > if there were just a few, once you did allyesconfig/allmodconfig for > ARM, MIPS, PPC, etc. I have tried this with non-x86 builds and apart of a few problems all looked fine. As it turns out I was using too old cross tools from kernel.org [1]. Luckily Fengguang's kbuild robot did catch a bunch of them (see the patches in this series). Since Thomas was also surprised that only a bunch of them showed up, I'll better give it another go with more recent compilers. cheers, daniel [1] https://www.kernel.org/pub/tools/crosstool From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Wagner Subject: Re: [PATCH tip v6 2/5] kbuild: Add option to turn incompatible pointer check into error Date: Mon, 1 Feb 2016 07:49:21 +0100 Message-ID: <56AEFFF1.1010404@bmw-carit.de> References: <1453992270-4688-1-git-send-email-daniel.wagner@bmw-carit.de> <1453992270-4688-3-git-send-email-daniel.wagner@bmw-carit.de> <56AB5867.6020405@bmw-carit.de> <20160129185523.GZ8889@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: , , , Marcelo Tosatti , Paolo Bonzini , "Paul E . McKenney" , Peter Zijlstra , Thomas Gleixner , Steven Rostedt , Boqun Feng To: Paul Gortmaker Return-path: In-Reply-To: <20160129185523.GZ8889@windriver.com> Sender: linux-kbuild-owner@vger.kernel.org List-Id: linux-rt-users.vger.kernel.org On 01/29/2016 07:55 PM, Paul Gortmaker wrote: > [Re: [PATCH tip v6 2/5] kbuild: Add option to turn incompatible pointer check into error] On 29/01/2016 (Fri 13:17) Daniel Wagner wrote: > >> On 01/28/2016 03:44 PM, Daniel Wagner wrote: >>> +# enforce correct pointer usage >>> +KBUILD_CFLAGS += $(call cc-option,-Werror=incompatible-pointer-types) >>> + >> >> As it turns out there are a few fallouts by that one. I'll send fixes >> for it. > > Did you try non-x86 builds with this applied? I'd be really surprised > if there were just a few, once you did allyesconfig/allmodconfig for > ARM, MIPS, PPC, etc. I have tried this with non-x86 builds and apart of a few problems all looked fine. As it turns out I was using too old cross tools from kernel.org [1]. Luckily Fengguang's kbuild robot did catch a bunch of them (see the patches in this series). Since Thomas was also surprised that only a bunch of them showed up, I'll better give it another go with more recent compilers. cheers, daniel [1] https://www.kernel.org/pub/tools/crosstool