From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH] soc: mediatek: SCPSYS: Fix double enabling of regulators Date: Mon, 1 Feb 2016 11:28:39 +0100 Message-ID: <56AF3357.1040707@gmail.com> References: <1453466365-24406-1-git-send-email-s.hauer@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Daniel Kurtz , Sascha Hauer Cc: "moderated list:ARM/Mediatek SoC support" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-mediatek@lists.infradead.org On 22/01/16 20:26, Daniel Kurtz wrote: > On Fri, Jan 22, 2016 at 4:39 AM, Sascha Hauer wrote: >> > >> >With CONFIG_PM enabled do not call genpd->power_on manually as this >> >will cause the regulators being turned on once in SCPSYS probe and >> >then again when the genpd core turns on the domains. Instead, call >> >genpd->power_on only with CONFIG_PM disabled and tell the genpd core >> >that the domains are disabled when registered. >> > >> >Signed-off-by: Sascha Hauer > Take your pick: > Tested-by: Daniel Kurtz > Reviewed-by: Daniel Kurtz > >> >--- Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: matthias.bgg@gmail.com (Matthias Brugger) Date: Mon, 1 Feb 2016 11:28:39 +0100 Subject: [PATCH] soc: mediatek: SCPSYS: Fix double enabling of regulators In-Reply-To: References: <1453466365-24406-1-git-send-email-s.hauer@pengutronix.de> Message-ID: <56AF3357.1040707@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 22/01/16 20:26, Daniel Kurtz wrote: > On Fri, Jan 22, 2016 at 4:39 AM, Sascha Hauer wrote: >> > >> >With CONFIG_PM enabled do not call genpd->power_on manually as this >> >will cause the regulators being turned on once in SCPSYS probe and >> >then again when the genpd core turns on the domains. Instead, call >> >genpd->power_on only with CONFIG_PM disabled and tell the genpd core >> >that the domains are disabled when registered. >> > >> >Signed-off-by: Sascha Hauer > Take your pick: > Tested-by: Daniel Kurtz > Reviewed-by: Daniel Kurtz > >> >--- Applied, thanks.