From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQCBZ-0002BL-Jv for qemu-devel@nongnu.org; Mon, 01 Feb 2016 05:58:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQCBW-0001PC-Bw for qemu-devel@nongnu.org; Mon, 01 Feb 2016 05:58:21 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:49498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQCBV-0001Nu-Pj for qemu-devel@nongnu.org; Mon, 01 Feb 2016 05:58:18 -0500 References: <1453883380-10532-1-git-send-email-zhang.zhanghailiang@huawei.com> <1453883380-10532-4-git-send-email-zhang.zhanghailiang@huawei.com> <20160201104346.GD1622@redhat.com> From: Hailiang Zhang Message-ID: <56AF3A24.1040201@huawei.com> Date: Mon, 1 Feb 2016 18:57:40 +0800 MIME-Version: 1.0 In-Reply-To: <20160201104346.GD1622@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: jasowang@redhat.com, hongyang.yang@easystack.cn, peter.huangpeng@huawei.com, zhangchen.fnst@cn.fujitsu.com, qemu-devel@nongnu.org On 2016/2/1 18:43, Daniel P. Berrange wrote: > On Wed, Jan 27, 2016 at 04:29:38PM +0800, zhanghailiang wrote: >> We add a new helper function netdev_add_filter(), this function >> can help adding a filter object to a netdev. >> Besides, we add a is_default member for struct NetFilterState >> to indicate whether the filter is default or not. >> >> Signed-off-by: zhanghailiang >> --- >> v2: >> -Re-implement netdev_add_filter() by re-using object_create() >> (Jason's suggestion) >> --- >> include/net/filter.h | 7 +++++ >> net/filter.c | 80 ++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 87 insertions(+) > >> +void netdev_add_filter(const char *netdev_id, >> + const char *filter_type, >> + const char *id, >> + bool is_default, >> + Error **errp) >> +{ >> + NetClientState *nc = qemu_find_netdev(netdev_id); >> + char *optarg; >> + QemuOpts *opts = NULL; >> + Error *err = NULL; >> + >> + /* FIXME: Not support multiple queues */ >> + if (!nc || nc->queue_index > 1) { >> + return; >> + } >> + /* Not support vhost-net */ >> + if (get_vhost_net(nc)) { >> + return; >> + } >> + >> + optarg = g_strdup_printf("qom-type=%s,id=%s,netdev=%s,status=%s", >> + filter_type, id, netdev_id, is_default ? "disable" : "enable"); >> + opts = qemu_opts_parse_noisily(&qemu_filter_opts, >> + optarg, false); > > Formatting a string and then immediately parsing it again is totally > crazy, not least because you're not taking care to do escaping of > special characters like ',' in the string parameters. > Got it. >> + if (!opts) { >> + error_report("Failed to parse param '%s'", optarg); >> + exit(1); >> + } >> + g_free(optarg); >> + if (object_create(NULL, opts, &err) < 0) { >> + error_report("Failed to create object"); >> + goto out_clean; >> + } > > Don't use object_create() - use object_new_with_props() which avoids > the need to format + parse the string above. ie do > > object_new_with_props(filter_type, > object_get_objects_root(), > id, > &err, > "netdev", netdev_id, > "status", is_default ? "disable" : "enable", > NULL); > > Ha, that's really a good idea, i will fix it like that in next version. Thank you very much. Hailiang > Regards, > Daniel >