From mboxrd@z Thu Jan  1 00:00:00 1970
From: Corneliu ZUZU <czuzu@bitdefender.com>
Subject: Re: [PATCH] x86: shrink 'struct domain',
	was already PAGE_SIZE
Date: Mon, 1 Feb 2016 12:58:21 +0200
Message-ID: <56AF3A4D.9080602@bitdefender.com>
References: <1454312541-12422-1-git-send-email-czuzu@bitdefender.com>
	<56AF45E402000078000CCDBD@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56AF45E402000078000CCDBD@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Keir Fraser <keir@xen.org>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 2/1/2016 12:47 PM, Jan Beulich wrote:
>>>> On 01.02.16 at 08:42, <czuzu@bitdefender.com> wrote:
>> The X86 domain structure already occupied PAGE_SIZE (4096).
>>
>> Looking @ the memory layout of the structure, we could see that
>> overall most was occupied by (used the pahole tool on domain.o):
>>   * sizeof(domain.arch) = sizeof(arch_domain) = 3328 bytes.
>>   * sizeof(domain.arch.hvm_domain) = 2224 bytes.
>>   * sizeof(domain.arch.hvm_domain.pl_time) = 1088 bytes.
>> This patch attempts to free some space, by making the pl_time
>> field in hvm_domain dynamically allocated.
>> We xzalloc/xfree it @ hvm_domain_initialise/hvm_domain_destroy.
>>
>> After this change, the domain structure shrunk w/ 1152 bytes (>1K!).
>>
>> Signed-off-by: Corneliu ZUZU <czuzu@bitdefender.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> albeit ...
>
>> --- a/xen/include/asm-x86/hvm/vpt.h
>> +++ b/xen/include/asm-x86/hvm/vpt.h
>> @@ -139,6 +139,9 @@ struct pl_time {    /* platform time */
>>       /* Ensures monotonicity in appropriate timer modes. */
>>       uint64_t last_guest_time;
>>       spinlock_t pl_time_lock;
>> +    /* pl_time allocated dynamically, need to keep link to
>> +     * containing domain */
>> +    struct domain *domain;
>>   };
> ... I wonder about the usefulness of this (malformed) comment. I'll
> likely ditch it while committing.
>
> Jan
>

Agreed, sorry about that and thanks.

Corneliu.