From: Hongxu Jia <hongxu.jia@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
Khem Raj <raj.khem@gmail.com>
Cc: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/5] gcc-5.3.inc/base.bbclass: add gcc option to not record -fdebug-prefix-map to debugging info
Date: Mon, 1 Feb 2016 22:01:28 +0800 [thread overview]
Message-ID: <56AF6538.9010000@windriver.com> (raw)
In-Reply-To: <1454151423.10340.84.camel@linuxfoundation.org>
On 01/30/2016 06:57 PM, Richard Purdie wrote:
> On Fri, 2016-01-29 at 18:36 -0800, Khem Raj wrote:
>>> On Jan 29, 2016, at 5:25 PM, Hongxu Jia <hongxu.jia@windriver.com>
>>> wrote:
>>>
>>> On 01/30/2016 01:47 AM, Peter Kjellerstedt wrote:
>>>> Wouldn't it be better to swap the first and second commit and
>>>> then
>>>> move the addition of -gno-record-debug-prefix-map to the other
>>>> commit
>>>> where -fdebug-prefix-map are added.
>>> OK
>>>
>>>> You must also remember that not all use the compiler provided by
>>>> OE-Core, so adding -gno-record-debug-prefix-map unconditionally
>>>> to
>>>> DEBUG_CFLAGS will break with unpatched compilers... (This also
>>>> indicates that "Upstream-Status: Inappropriate [oe specific]" may
>>>> not be quite right if you want this to be supported by other
>>>> compiler versions).
>>> Agree, we should conditionally add -gno-record-debug-prefix-map to
>>> support other compiler. Thank you for pointing it out.
>> its not only non gcc compilers, we also have gcc 4.9 still.
> I think we do likely need to patch 4.9. For other compilers than that,
> or other compilers, I'd suggest that people can either define a set of
> DEBUG_CFLAGS, or set:
>
> DEBUG_CFLAGS_remove = "-gno-record-debug-prefix-map"
>
> to avoid problems. I'm not sure making it conditional in some way is
> any better than just using the above line.
Got it, I will do it in V4.
//Hongxu
> Cheers,
>
> Richard
next prev parent reply other threads:[~2016-02-01 14:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 17:35 [PATCH v3 0/5]use target path to replace build ones in debugging info Hongxu Jia
2016-01-29 17:35 ` [PATCH 1/5] base/bbclass: use target path as compile dir " Hongxu Jia
2016-01-29 17:48 ` Peter Kjellerstedt
2016-01-30 1:15 ` Hongxu Jia
2016-01-29 17:35 ` [PATCH 2/5] gcc-5.3.inc/base.bbclass: add gcc option to not record -fdebug-prefix-map to " Hongxu Jia
2016-01-29 17:47 ` Peter Kjellerstedt
2016-01-30 1:25 ` Hongxu Jia
2016-01-30 2:36 ` Khem Raj
2016-01-30 10:57 ` Richard Purdie
2016-02-01 14:01 ` Hongxu Jia [this message]
2016-02-01 14:09 ` Richard Purdie
2016-02-01 17:10 ` Khem Raj
2016-02-07 16:17 ` Hongxu Jia
2016-01-30 11:43 ` Phil Blundell
2016-02-20 13:00 ` Martin Jansa
2016-02-20 15:02 ` Khem Raj
2016-02-22 6:44 ` Hongxu Jia
2016-02-22 15:35 ` Martin Jansa
2016-01-29 17:35 ` [PATCH 3/5] mkelfimage: fix target cflags leaks to host Hongxu Jia
2016-01-29 17:35 ` [PATCH 4/5] glibc.inc: do not immediate expand SELECTED_OPTIMIZATION Hongxu Jia
2016-01-30 10:35 ` Phil Blundell
2016-01-29 17:35 ` [PATCH 5/5] systemtap_git.inc: " Hongxu Jia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AF6538.9010000@windriver.com \
--to=hongxu.jia@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.kjellerstedt@axis.com \
--cc=raj.khem@gmail.com \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.