From: Steve Lawrence <slawrence@tresys.com>
To: Nicolas Iooss <nicolas.iooss@m4x.org>, <selinux@tycho.nsa.gov>
Subject: Re: [PATCH] policycoreutils: newrole: add missing defined in #if
Date: Mon, 1 Feb 2016 09:14:01 -0500 [thread overview]
Message-ID: <56AF6829.7030509@tresys.com> (raw)
In-Reply-To: <1453220308-2967-1-git-send-email-nicolas.iooss@m4x.org>
On 01/19/2016 11:18 AM, Nicolas Iooss wrote:
> When building newrole with gcc 5.3.0 and some warning flags, the
> compiler reports:
>
> newrole.c:77:33: error: "NAMESPACE_PRIV" is not defined [-Werror=undef]
> #if defined(AUDIT_LOG_PRIV) || (NAMESPACE_PRIV)
> ^
>
> Indeed, "defined" is missing here. This nevertheless worked so far
> because when NAMESPACE_PRIV was selected in the Makefile, newrole.c was
> compiled with "-DNAMESPACE_PRIV", which defined NAMESPACE_PRIV to 1.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
Patch applied. Thanks!
- Steve
> ---
> policycoreutils/newrole/newrole.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/policycoreutils/newrole/newrole.c b/policycoreutils/newrole/newrole.c
> index 65a945d3d3f3..c6544eed07b9 100644
> --- a/policycoreutils/newrole/newrole.c
> +++ b/policycoreutils/newrole/newrole.c
> @@ -74,7 +74,7 @@
> #ifdef USE_AUDIT
> #include <libaudit.h>
> #endif
> -#if defined(AUDIT_LOG_PRIV) || (NAMESPACE_PRIV)
> +#if defined(AUDIT_LOG_PRIV) || defined(NAMESPACE_PRIV)
> #include <sys/prctl.h>
> #include <cap-ng.h>
> #endif
>
prev parent reply other threads:[~2016-02-01 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 16:18 [PATCH] policycoreutils: newrole: add missing defined in #if Nicolas Iooss
2016-02-01 14:14 ` Steve Lawrence [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AF6829.7030509@tresys.com \
--to=slawrence@tresys.com \
--cc=nicolas.iooss@m4x.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.