From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: BUG caused by "Use new drm_fb_helper functions" series Date: Mon, 1 Feb 2016 12:37:05 -0800 Message-ID: <56AFC1F1.5080507@hurleysoftware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf0-f171.google.com (mail-pf0-f171.google.com [209.85.192.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id D6E076E4EF for ; Mon, 1 Feb 2016 12:37:07 -0800 (PST) Received: by mail-pf0-f171.google.com with SMTP id x125so90021176pfb.0 for ; Mon, 01 Feb 2016 12:37:07 -0800 (PST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja , Daniel Vetter , Ben Skeggs Cc: Linux kernel , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org SGkgQXJjaGl0LAoKSnVzdCBib290aW5nIDQuNC1yYzUrLCBJIGdvdCB0aGlzIHNwbGF0IFsxXQpB dCBmaXJzdCBnbGFuY2UsIHRoaXMgYXBwZWFycyB0byBiZSBhIHNpbXBsZSBmaXguCgpIb3dldmVy LCBJJ20gY29uY2VybmVkIHRoYXQgZmJjb24gZnVuY3Rpb25zLCB3aGljaCBtYXkgYmUgY2FsbGVk IHdpdGgKaW50ZXJydXB0cyBkaXNhYmxlZCwgYXJlIG5vdyBob29rZWQgdXAgdG8gZmJkZXYgZnVu Y3Rpb25zIHdoaWNoIG1heSBhc3N1bWUKaW50ZXJydXB0cyBhcmUgbm90IGRpc2FibGVkIChhcyBp cyB0aGUgY2FzZSB3aXRoIGNmYl9pbWFnZWJsaXQoKSkuCgpGb3IgZXhhbXBsZSwgaW4gdGhlIHNw bGF0IGJlbG93LCBpdCdzIGEgc2ltcGxlIGZpeCB0byBtYWtlIHRoZSBzcGxhdCBnbwphd2F5IHdp dGggR0ZQX0FUT01JQyBhbGxvY2F0aW9uLiBIb3dldmVyLCB0aGUgZm9sbG93aW5nIGZlbmNlIHdh aXQgaXMgX25ldmVyXwpnb2luZyB0byB0cmlnZ2VyIHdpdGggaW50ZXJydXB0cyBkaXNhYmxlZCBv biBVUC4KCkZXSVcsIEkndmUgYmVlbiBydW5uaW5nIGFsbW9zdCBleGNsdXNpdmVseSBkZWJ1ZyBr ZXJuZWwgYnVpbGRzIHNvIEknbSBub3QKc3VyZSB3aHkgdGhpcyBoYXNuJ3QgdHJpZ2dlcmVkIG1h bnkgdGltZXMgYmVmb3JlLCBidXQgaXQgaGFzbid0LgoKUmVnYXJkcywKUGV0ZXIgSHVybGV5CgoK WzFdIEJVRyBzcGxhdAoKWyAgIDM3LjQzODQ5NF0gQlVHOiBzbGVlcGluZyBmdW5jdGlvbiBjYWxs ZWQgZnJvbSBpbnZhbGlkIGNvbnRleHQgYXQgL2hvbWUvcGV0ZXIvc3JjL2tlcm5lbHMvbWFpbmxp bmUvbW0vc2x1Yi5jOjEyODcKWyAgIDM3LjQzODQ5NV0gaW5fYXRvbWljKCk6IDEsIGlycXNfZGlz YWJsZWQoKTogMSwgcGlkOiAyMjc2LCBuYW1lOiBhdWRpdGQKWyAgIDM3LjQzODQ5N10gMSBsb2Nr IGhlbGQgYnkgYXVkaXRkLzIyNzY6ClsgICAzNy40Mzg1MDddICAjMDogIChhdWRpdF9jbWRfbXV0 ZXgpeysuKy4rLn0sIGF0OiBbPGZmZmZmZmZmODExM2E2M2Y+XSBhdWRpdF9yZWNlaXZlKzB4MWYv MHhhMApbICAgMzcuNDM4NTA3XSBpcnEgZXZlbnQgc3RhbXA6IDE2ODkKWyAgIDM3LjQzODUxMV0g aGFyZGlycXMgbGFzdCAgZW5hYmxlZCBhdCAoMTY4OSk6IFs8ZmZmZmZmZmY4MTBlOWE5Nj5dIHZw cmludGtfZW1pdCsweDIzNi8weDYyMApbICAgMzcuNDM4NTEzXSBoYXJkaXJxcyBsYXN0IGRpc2Fi bGVkIGF0ICgxNjg4KTogWzxmZmZmZmZmZjgxMGU5OTM0Pl0gdnByaW50a19lbWl0KzB4ZDQvMHg2 MjAKWyAgIDM3LjQzODUxOF0gc29mdGlycXMgbGFzdCAgZW5hYmxlZCBhdCAoMTY1Mik6IFs8ZmZm ZmZmZmY4MTc1Mzg5OD5dIG5ldGxpbmtfcG9sbCsweDEzOC8weDFjMApbICAgMzcuNDM4NTIwXSBz b2Z0aXJxcyBsYXN0IGRpc2FibGVkIGF0ICgxNjUwKTogWzxmZmZmZmZmZjgxNzUzODU3Pl0gbmV0 bGlua19wb2xsKzB4ZjcvMHgxYzAKWyAgIDM3LjQzODUyMl0gQ1BVOiA3IFBJRDogMjI3NiBDb21t OiBhdWRpdGQgTm90IHRhaW50ZWQgNC40LjAtcmM1K3dpcC14ZW9uK2RlYnVnICNyYzUrd2lwClsg ICAzNy40Mzg1MjNdIEhhcmR3YXJlIG5hbWU6IERlbGwgSW5jLiBQcmVjaXNpb24gV29ya1N0YXRp b24gVDU0MDAgIC8wUlcyMDMsIEJJT1MgQTExIDA0LzMwLzIwMTIKWyAgIDM3LjQzODUyNl0gIGZm ZmZmZmZmODFjZTVjYzggZmZmZjg4MDJhODdjMzU5MCBmZmZmZmZmZjgxM2ZiNmM1IGZmZmY4ODAy YWM3NjgwMDAKWyAgIDM3LjQzODUyOF0gIGZmZmY4ODAyYTg3YzM1YjggZmZmZmZmZmY4MTBhNmZi OSBmZmZmZmZmZjgxY2U1Y2M4IDAwMDAwMDAwMDAwMDA1MDcKWyAgIDM3LjQzODUzMF0gIDAwMDAw MDAwMDAwMDAwMDAgZmZmZjg4MDJhODdjMzVlMCBmZmZmZmZmZjgxMGE3MGI5IDAwMDAwMDAwMDI0 MDgwYzAKWyAgIDM3LjQzODUzMV0gQ2FsbCBUcmFjZToKWyAgIDM3LjQzODUzNV0gIFs8ZmZmZmZm ZmY4MTNmYjZjNT5dIGR1bXBfc3RhY2srMHg0ZS8weDc5ClsgICAzNy40Mzg1MzhdICBbPGZmZmZm ZmZmODEwYTZmYjk+XSBfX19taWdodF9zbGVlcCsweDE0OS8weDIwMApbICAgMzcuNDM4NTQwXSAg WzxmZmZmZmZmZjgxMGE3MGI5Pl0gX19taWdodF9zbGVlcCsweDQ5LzB4ODAKWyAgIDM3LjQzODU0 NF0gIFs8ZmZmZmZmZmY4MTIwMmRmZD5dIGttZW1fY2FjaGVfYWxsb2NfdHJhY2UrMHgyMGQvMHgy ZTAKWyAgIDM3LjQzODYwMF0gIFs8ZmZmZmZmZmZhMDI3MmU5Yj5dID8gbm91dmVhdV9mZW5jZV9u ZXcrMHgzYi8weDkwIFtub3V2ZWF1XQpbICAgMzcuNDM4NjI0XSAgWzxmZmZmZmZmZmEwMjcyZTli Pl0gbm91dmVhdV9mZW5jZV9uZXcrMHgzYi8weDkwIFtub3V2ZWF1XQpbICAgMzcuNDM4NjQ5XSAg WzxmZmZmZmZmZmEwMjcwN2IyPl0gbm91dmVhdV9jaGFubmVsX2lkbGUrMHg0Mi8weGIwIFtub3V2 ZWF1XQpbICAgMzcuNDM4NjczXSAgWzxmZmZmZmZmZmEwMjZiYjNmPl0gbm91dmVhdV9mYmNvbl9z eW5jKzB4N2YvMHhiMCBbbm91dmVhdV0KWyAgIDM3LjQzODY3N10gIFs8ZmZmZmZmZmY4MTQ4OTk4 YT5dIGNmYl9pbWFnZWJsaXQrMHg5YS8weDRkMApbICAgMzcuNDM4NjgxXSAgWzxmZmZmZmZmZjgx MGQyMmVmPl0gPyB0cmFjZV9oYXJkaXJxc19vZmZfY2FsbGVyKzB4MWYvMHhjMApbICAgMzcuNDM4 NjkzXSAgWzxmZmZmZmZmZmEwMTNkMzBlPl0gZHJtX2ZiX2hlbHBlcl9jZmJfaW1hZ2VibGl0KzB4 ZS8weDEwIFtkcm1fa21zX2hlbHBlcl0KWyAgIDM3LjQzODcxN10gIFs8ZmZmZmZmZmZhMDI2YmJj MT5dIG5vdXZlYXVfZmJjb25faW1hZ2VibGl0KzB4NTEvMHhkMCBbbm91dmVhdV0KWyAgIDM3LjQz ODcxOV0gIFs8ZmZmZmZmZmY4MTQ3YzAyYz5dIGJpdF9wdXRjcysweDJkYy8weDUzMApbICAgMzcu NDM4NzIxXSAgWzxmZmZmZmZmZjgxMGQyMzlkPl0gPyB0cmFjZV9oYXJkaXJxc19vZmYrMHhkLzB4 MTAKWyAgIDM3LjQzODcyNV0gIFs8ZmZmZmZmZmY4MTQ3NjE0ND5dID8gZ2V0X2NvbG9yLmlzcmEu MTUrMHgzNC8weDEzMApbICAgMzcuNDM4NzI3XSAgWzxmZmZmZmZmZjgxNDc3Mjc4Pl0gZmJjb25f cHV0Y3MrMHgxMjgvMHgxNjAKWyAgIDM3LjQzODcyOF0gIFs8ZmZmZmZmZmY4MTQ3YmQ1MD5dID8g Yml0X2N1cnNvcisweDVlMC8weDVlMApbICAgMzcuNDM4NzMwXSAgWzxmZmZmZmZmZjgxNDc3NTZi Pl0gZmJjb25fcmVkcmF3LmlzcmEuMjUrMHgxNmIvMHgxZDAKWyAgIDM3LjQzODczMV0gIFs8ZmZm ZmZmZmY4MTQ3ODk0YT5dIGZiY29uX3Njcm9sbCsweDFlYS8weGNlMApbICAgMzcuNDM4NzM0XSAg WzxmZmZmZmZmZjgxNTExMmNhPl0gc2NydXArMHgxNGEvMHgxNjAKWyAgIDM3LjQzODczNl0gIFs8 ZmZmZmZmZmY4MTUxMTM2MD5dIGxmKzB4ODAvMHg5MApbICAgMzcuNDM4NzM3XSAgWzxmZmZmZmZm ZjgxNTExNjE3Pl0gdnRfY29uc29sZV9wcmludCsweDJhNy8weDNlMApbICAgMzcuNDM4NzM5XSAg WzxmZmZmZmZmZjgxMGU4OWM0Pl0gY2FsbF9jb25zb2xlX2RyaXZlcnMuY29uc3Rwcm9wLjI0KzB4 MTQ0LzB4MWQwClsgICAzNy40Mzg3NDFdICBbPGZmZmZmZmZmODEwZTk3ODM+XSBjb25zb2xlX3Vu bG9jaysweDQ2My8weDU0MApbICAgMzcuNDM4NzQyXSAgWzxmZmZmZmZmZjgxMGU5YmJhPl0gdnBy aW50a19lbWl0KzB4MzVhLzB4NjIwClsgICAzNy40Mzg3NDRdICBbPGZmZmZmZmZmODEwZTlmZDk+ XSB2cHJpbnRrX2RlZmF1bHQrMHgyOS8weDQwClsgICAzNy40Mzg3NDhdICBbPGZmZmZmZmZmODEx OWY3MWE+XSBwcmludGsrMHg0ZC8weDRmClsgICAzNy40Mzg3NTBdICBbPGZmZmZmZmZmODExMzdh ZDI+XSBhdWRpdF9wcmludGtfc2tiKzB4NjIvMHg3MApbICAgMzcuNDM4NzUxXSAgWzxmZmZmZmZm ZjgxMTM3ZTg0Pl0gYXVkaXRfbG9nX2VuZCsweDFkNC8weDJkMApbICAgMzcuNDM4NzUyXSAgWzxm ZmZmZmZmZjgxMTM3Y2UwPl0gPyBhdWRpdF9sb2dfZW5kKzB4MzAvMHgyZDAKWyAgIDM3LjQzODc1 NF0gIFs8ZmZmZmZmZmY4MTEzOTA1OT5dIGF1ZGl0X2xvZ19jb25maWdfY2hhbmdlKzB4ODkvMHhh MApbICAgMzcuNDM4NzU2XSAgWzxmZmZmZmZmZjgxMTNhNGNhPl0gYXVkaXRfcmVjZWl2ZV9tc2cr MHhhNWEvMHhiYjAKWyAgIDM3LjQzODc1OV0gIFs8ZmZmZmZmZmY4MTg0ODFiZD5dID8gbXV0ZXhf bG9ja19uZXN0ZWQrMHgyZWQvMHg0NTAKWyAgIDM3LjQzODc2MV0gIFs8ZmZmZmZmZmY4MTEzYTYz Zj5dID8gYXVkaXRfcmVjZWl2ZSsweDFmLzB4YTAKWyAgIDM3LjQzODc2Ml0gIFs8ZmZmZmZmZmY4 MTEzYTYzZj5dID8gYXVkaXRfcmVjZWl2ZSsweDFmLzB4YTAKWyAgIDM3LjQzODc2NF0gIFs8ZmZm ZmZmZmY4MTEzYTY3Mj5dIGF1ZGl0X3JlY2VpdmUrMHg1Mi8weGEwClsgICAzNy40Mzg3NjZdICBb PGZmZmZmZmZmODE3NTU2NTI+XSBuZXRsaW5rX3VuaWNhc3QrMHhmMi8weDFjMApbICAgMzcuNDM4 NzY3XSAgWzxmZmZmZmZmZjgxNzU1YjA3Pl0gbmV0bGlua19zZW5kbXNnKzB4M2U3LzB4NjIwClsg ICAzNy40Mzg3NzFdICBbPGZmZmZmZmZmODE2ZmY0ZTg+XSBzb2NrX3NlbmRtc2crMHgzOC8weDUw ClsgICAzNy40Mzg3NzJdICBbPGZmZmZmZmZmODE2ZmY5NDY+XSBTWVNDX3NlbmR0bysweGY2LzB4 MTcwClsgICAzNy40Mzg3NzVdICBbPGZmZmZmZmZmODExOWRiOGQ+XSA/IGNvbnRleHRfdHJhY2tp bmdfZXhpdCsweDFkLzB4MzAKWyAgIDM3LjQzODc3OF0gIFs8ZmZmZmZmZmY4MTAwMzY3Zj5dID8g ZW50ZXJfZnJvbV91c2VyX21vZGUrMHgxZi8weDUwClsgICAzNy40Mzg3ODBdICBbPGZmZmZmZmZm ODEwMDM3N2I+XSA/IHN5c2NhbGxfdHJhY2VfZW50ZXJfcGhhc2UxKzB4Y2IvMHgxMzAKWyAgIDM3 LjQzODc4MV0gIFs8ZmZmZmZmZmY4MTAwMzAxNz5dID8gdHJhY2VfaGFyZGlycXNfb25fdGh1bmsr MHgxNy8weDE5ClsgICAzNy40Mzg3ODRdICBbPGZmZmZmZmZmODE3MDA3OWU+XSBTeVNfc2VuZHRv KzB4ZS8weDEwClsgICAzNy40Mzg3ODZdICBbPGZmZmZmZmZmODE4NGJlMzY+XSBlbnRyeV9TWVND QUxMXzY0X2Zhc3RwYXRoKzB4MTYvMHg3YQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753882AbcBAUhL (ORCPT ); Mon, 1 Feb 2016 15:37:11 -0500 Received: from mail-pf0-f170.google.com ([209.85.192.170]:35385 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752872AbcBAUhH (ORCPT ); Mon, 1 Feb 2016 15:37:07 -0500 From: Peter Hurley To: Archit Taneja , Daniel Vetter , Ben Skeggs Cc: David Airlie , "dri-devel@lists.freedesktop.org" , Linux kernel Subject: BUG caused by "Use new drm_fb_helper functions" series Message-ID: <56AFC1F1.5080507@hurleysoftware.com> Date: Mon, 1 Feb 2016 12:37:05 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Archit, Just booting 4.4-rc5+, I got this splat [1] At first glance, this appears to be a simple fix. However, I'm concerned that fbcon functions, which may be called with interrupts disabled, are now hooked up to fbdev functions which may assume interrupts are not disabled (as is the case with cfb_imageblit()). For example, in the splat below, it's a simple fix to make the splat go away with GFP_ATOMIC allocation. However, the following fence wait is _never_ going to trigger with interrupts disabled on UP. FWIW, I've been running almost exclusively debug kernel builds so I'm not sure why this hasn't triggered many times before, but it hasn't. Regards, Peter Hurley [1] BUG splat [ 37.438494] BUG: sleeping function called from invalid context at /home/peter/src/kernels/mainline/mm/slub.c:1287 [ 37.438495] in_atomic(): 1, irqs_disabled(): 1, pid: 2276, name: auditd [ 37.438497] 1 lock held by auditd/2276: [ 37.438507] #0: (audit_cmd_mutex){+.+.+.}, at: [] audit_receive+0x1f/0xa0 [ 37.438507] irq event stamp: 1689 [ 37.438511] hardirqs last enabled at (1689): [] vprintk_emit+0x236/0x620 [ 37.438513] hardirqs last disabled at (1688): [] vprintk_emit+0xd4/0x620 [ 37.438518] softirqs last enabled at (1652): [] netlink_poll+0x138/0x1c0 [ 37.438520] softirqs last disabled at (1650): [] netlink_poll+0xf7/0x1c0 [ 37.438522] CPU: 7 PID: 2276 Comm: auditd Not tainted 4.4.0-rc5+wip-xeon+debug #rc5+wip [ 37.438523] Hardware name: Dell Inc. Precision WorkStation T5400 /0RW203, BIOS A11 04/30/2012 [ 37.438526] ffffffff81ce5cc8 ffff8802a87c3590 ffffffff813fb6c5 ffff8802ac768000 [ 37.438528] ffff8802a87c35b8 ffffffff810a6fb9 ffffffff81ce5cc8 0000000000000507 [ 37.438530] 0000000000000000 ffff8802a87c35e0 ffffffff810a70b9 00000000024080c0 [ 37.438531] Call Trace: [ 37.438535] [] dump_stack+0x4e/0x79 [ 37.438538] [] ___might_sleep+0x149/0x200 [ 37.438540] [] __might_sleep+0x49/0x80 [ 37.438544] [] kmem_cache_alloc_trace+0x20d/0x2e0 [ 37.438600] [] ? nouveau_fence_new+0x3b/0x90 [nouveau] [ 37.438624] [] nouveau_fence_new+0x3b/0x90 [nouveau] [ 37.438649] [] nouveau_channel_idle+0x42/0xb0 [nouveau] [ 37.438673] [] nouveau_fbcon_sync+0x7f/0xb0 [nouveau] [ 37.438677] [] cfb_imageblit+0x9a/0x4d0 [ 37.438681] [] ? trace_hardirqs_off_caller+0x1f/0xc0 [ 37.438693] [] drm_fb_helper_cfb_imageblit+0xe/0x10 [drm_kms_helper] [ 37.438717] [] nouveau_fbcon_imageblit+0x51/0xd0 [nouveau] [ 37.438719] [] bit_putcs+0x2dc/0x530 [ 37.438721] [] ? trace_hardirqs_off+0xd/0x10 [ 37.438725] [] ? get_color.isra.15+0x34/0x130 [ 37.438727] [] fbcon_putcs+0x128/0x160 [ 37.438728] [] ? bit_cursor+0x5e0/0x5e0 [ 37.438730] [] fbcon_redraw.isra.25+0x16b/0x1d0 [ 37.438731] [] fbcon_scroll+0x1ea/0xce0 [ 37.438734] [] scrup+0x14a/0x160 [ 37.438736] [] lf+0x80/0x90 [ 37.438737] [] vt_console_print+0x2a7/0x3e0 [ 37.438739] [] call_console_drivers.constprop.24+0x144/0x1d0 [ 37.438741] [] console_unlock+0x463/0x540 [ 37.438742] [] vprintk_emit+0x35a/0x620 [ 37.438744] [] vprintk_default+0x29/0x40 [ 37.438748] [] printk+0x4d/0x4f [ 37.438750] [] audit_printk_skb+0x62/0x70 [ 37.438751] [] audit_log_end+0x1d4/0x2d0 [ 37.438752] [] ? audit_log_end+0x30/0x2d0 [ 37.438754] [] audit_log_config_change+0x89/0xa0 [ 37.438756] [] audit_receive_msg+0xa5a/0xbb0 [ 37.438759] [] ? mutex_lock_nested+0x2ed/0x450 [ 37.438761] [] ? audit_receive+0x1f/0xa0 [ 37.438762] [] ? audit_receive+0x1f/0xa0 [ 37.438764] [] audit_receive+0x52/0xa0 [ 37.438766] [] netlink_unicast+0xf2/0x1c0 [ 37.438767] [] netlink_sendmsg+0x3e7/0x620 [ 37.438771] [] sock_sendmsg+0x38/0x50 [ 37.438772] [] SYSC_sendto+0xf6/0x170 [ 37.438775] [] ? context_tracking_exit+0x1d/0x30 [ 37.438778] [] ? enter_from_user_mode+0x1f/0x50 [ 37.438780] [] ? syscall_trace_enter_phase1+0xcb/0x130 [ 37.438781] [] ? trace_hardirqs_on_thunk+0x17/0x19 [ 37.438784] [] SyS_sendto+0xe/0x10 [ 37.438786] [] entry_SYSCALL_64_fastpath+0x16/0x7a