From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQLcO-0003hm-IV for qemu-devel@nongnu.org; Mon, 01 Feb 2016 16:02:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQLcN-0003RC-OC for qemu-devel@nongnu.org; Mon, 01 Feb 2016 16:02:40 -0500 References: <1454106932-17236-1-git-send-email-jsnow@redhat.com> From: =?UTF-8?Q?Herv=c3=a9_Poussineau?= Message-ID: <56AFC7E1.4020500@reactos.org> Date: Mon, 1 Feb 2016 22:02:25 +0100 MIME-Version: 1.0 In-Reply-To: <1454106932-17236-1-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] fdc: fix detection under Linux List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: pbonzini@redhat.com, qemu-devel@nongnu.org Le 29/01/2016 23:35, John Snow a =E9crit : > Accidentally, I removed a "feature" where empty drives had geometry > values applied to them, which allows seek on empty drives to work > "by accident," as QEMU actually tries to disallow that. > > Seeks on empty drives should work, though, but the easiest thing is to > restore the misfeature where empty drives have non-zero geometries > applied. > > Document the hack accordingly. > > Signed-off-by: John Snow > --- > hw/block/fdc.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) Tested-by: Herv=E9 Poussineau