From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQNIl-0002ZF-5R for qemu-devel@nongnu.org; Mon, 01 Feb 2016 17:50:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQNIg-0001VI-32 for qemu-devel@nongnu.org; Mon, 01 Feb 2016 17:50:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQNIf-0001V3-Tc for qemu-devel@nongnu.org; Mon, 01 Feb 2016 17:50:26 -0500 References: <1454075341-13658-1-git-send-email-eblake@redhat.com> <1454075341-13658-11-git-send-email-eblake@redhat.com> <874mds7gsp.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56AFE130.7090803@redhat.com> Date: Mon, 1 Feb 2016 15:50:24 -0700 MIME-Version: 1.0 In-Reply-To: <874mds7gsp.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4nDUatVUWCxhdGwmuOO5XJLhGfgKn0ROF" Subject: Re: [Qemu-devel] [PATCH v10 10/25] qapi: Improve generated event use of qapi visitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4nDUatVUWCxhdGwmuOO5XJLhGfgKn0ROF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/01/2016 05:31 AM, Markus Armbruster wrote: >> |+ visit_start_struct(v, NULL, NULL, "ACPI_DEVICE_OST", 0, &err); >> | if (err) { >> | goto out; >> | } >> | visit_type_ACPIOSTInfo(v, &info, "info", &err); >> | if (err) { >> |- goto out; >> |+ goto out_obj; >> | } >> |- visit_end_struct(v, &err); >> |+out_obj: >> |+ visit_end_struct(v, err ? NULL : &err); >=20 > Slightly awkward example, because out_obj is pointless in this > degenerated case. You could pick one with multiple members (thus > multiple goto out_obj), or do pseudo-code hinting at multiple members. DEVICE_DELETED, DEVICE_TRAY_MOVED, MEM_UNPLUG_ERROR, NET_RX_FILTER_CHANGED, and SPICE_CONNECTED are nice candidates (two members instead of one). Do you want to take care of redoing any portion of the commit message? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4nDUatVUWCxhdGwmuOO5XJLhGfgKn0ROF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWr+EwAAoJEKeha0olJ0Nqj4IIAIgBi/NNoySRKCEvHNJK7NlD EUiTU7Fv2x0q0bZypbjMiC9HtkpXkFSMNLENW4eiTOEvLFBRN/aM+KHWbdBqwcgg 8IkLMPmA22hmlMJKRhsQ9mYHxLXQW/0VyQAyeaTQFyOh3InCFS/Wd3gNHvFzywWN wr5S1tX4su5NHf1LPazObiTh5YDx+llI2l1eeBarOBzXi+0pPLBCvJOHABPVk4t/ d6IP+J6UQQ4yW0Kr9pVPWIrqIQY7SaXuvCHvhTPUc7x5M0Mn0Itdm2g2KkOEN7I1 LbRzxKLhsDsSQYNaX8PBZGoJoA4HpnI1K6BOXVVyYsuGosWIYk6VHh0BN9GMdqk= =fNSz -----END PGP SIGNATURE----- --4nDUatVUWCxhdGwmuOO5XJLhGfgKn0ROF--