From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQNg6-0005Xo-SC for qemu-devel@nongnu.org; Mon, 01 Feb 2016 18:14:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQNg3-0004NX-GP for qemu-devel@nongnu.org; Mon, 01 Feb 2016 18:14:38 -0500 References: <1454075341-13658-1-git-send-email-eblake@redhat.com> <1454075341-13658-24-git-send-email-eblake@redhat.com> <87oac060k9.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56AFE6D8.1050500@redhat.com> Date: Mon, 1 Feb 2016 16:14:32 -0700 MIME-Version: 1.0 In-Reply-To: <87oac060k9.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="u2fEo8nar9sgipJgI9iIb6lqqKU5jEpB0" Subject: Re: [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Michael Roth , Alexander Graf , qemu-devel@nongnu.org, "open list:sPAPR" , marcandre.lureau@redhat.com, David Gibson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --u2fEo8nar9sgipJgI9iIb6lqqKU5jEpB0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/01/2016 06:07 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> No backend was setting an error when ending an implicit struct, >> or when iterating a list. >=20 > Perhaps "when ending the visit of a list or implicit struct, or when > moving to the next list node" would be more precise. If you like it, I= > can do that on commit. >=20 >> Make the callers a bit easier to follow >> by making this a part of the contract, and removing the errp >> argument - callers can then unconditionally end an object as >> part of cleanup without having to think about whether a second >> error is dominated by a first, because there is no second error. >> >> A later patch will then tackle the larger task of splitting >> visit_end_struct(), which can indeed set an error (and that >> cleanup will also have the side-effect of removing the use of >> error_abort added here). Oh, while you're touching this up, the last half of this sentence is now stale (since the addition of &error_abort was split out into 22/25 instead); I'd just delete the entire parenthetical, ending with "indeed set an error." --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --u2fEo8nar9sgipJgI9iIb6lqqKU5jEpB0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWr+bZAAoJEKeha0olJ0NqnMcH/jSYMinKkusDustPc8mZgwBK Iu849Lk9VcDI173acxLcjKck3TW+Q0eVkS+BDQOsgpnY4NkMnpz367gG9Vcdvbry C03yZyhZUmuII3g7sAUY11gj0B83bXPpN+5jZuVyJjsR0wQXAPfUSDpBazQmZiCd 8i682ToQfFhM5HLW3F8owkNND2o8Lq9rlcelecJ+VmrJ7/ne2ZnnNOiNsNf/0Qf0 P7zISLEpSh9xZv79LkLegFzRiyk5YvsQuWLpK5RSo4Mkq5lmQyx4K1DEUIdFmtd5 k6j8xr9i+h/24Q7tqEAOig4fOQSemypRNe28JfjuvrXTPRYRtec5dd67qSmPbIY= =LjUi -----END PGP SIGNATURE----- --u2fEo8nar9sgipJgI9iIb6lqqKU5jEpB0--