From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aQUzj-0006bZ-Ix for mharc-qemu-trivial@gnu.org; Tue, 02 Feb 2016 02:03:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQUzh-0006Xr-D5 for qemu-trivial@nongnu.org; Tue, 02 Feb 2016 02:03:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQUzg-0000OO-Jl for qemu-trivial@nongnu.org; Tue, 02 Feb 2016 02:03:21 -0500 Received: from isrv.corpit.ru ([86.62.121.231]:56919) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQUza-0000M3-Id; Tue, 02 Feb 2016 02:03:14 -0500 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 7411440188; Tue, 2 Feb 2016 10:03:04 +0300 (MSK) To: Peter Maydell , Wei Huang References: <1454347206-23717-1-git-send-email-wei@redhat.com> <1454347206-23717-2-git-send-email-wei@redhat.com> From: Michael Tokarev Openpgp: id=6EE195D1886E8FFB810D4324457CE0A0804465C5 Organization: Telecom Service, JSC Message-ID: <56B054A8.6020602@msgid.tls.msk.ru> Date: Tue, 2 Feb 2016 10:03:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 86.62.121.231 Cc: QEMU Trivial , Igor Mammedov , Shannon Zhao , QEMU Developers , Shannon Zhao Subject: Re: [Qemu-trivial] [PATCH 2/2] ARM: PL061: Misc cleaning fields for PL061 device state X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 07:03:22 -0000 01.02.2016 21:01, Peter Maydell wrote: > On 1 February 2016 at 17:20, Wei Huang wrote: >> This patch removes float_high field of PL061State, which doesn't seem >> to be used anywhere. [] >> @@ -88,7 +87,6 @@ static const VMStateDescription vmstate_pl061 = { >> VMSTATE_UINT32(slr, PL061State), >> VMSTATE_UINT32(den, PL061State), >> VMSTATE_UINT32(cr, PL061State), >> - VMSTATE_UINT32(float_high, PL061State), >> VMSTATE_UINT32_V(amsel, PL061State, 2), >> VMSTATE_END_OF_LIST() > > This would be a migration compatibility break, so at a minimum > you need to bump the vmstate struct versions. Is it worth the effort to remove this field if it causes compatibility break? Maybe keep it around, it doesn't hurt? At the very least, we may rename it to "unused_float_high", or something, to indicate it is a known-unused? Thanks, /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQUzf-0006Wc-PX for qemu-devel@nongnu.org; Tue, 02 Feb 2016 02:03:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQUza-0000N3-Q0 for qemu-devel@nongnu.org; Tue, 02 Feb 2016 02:03:19 -0500 References: <1454347206-23717-1-git-send-email-wei@redhat.com> <1454347206-23717-2-git-send-email-wei@redhat.com> From: Michael Tokarev Message-ID: <56B054A8.6020602@msgid.tls.msk.ru> Date: Tue, 2 Feb 2016 10:03:04 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] ARM: PL061: Misc cleaning fields for PL061 device state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Wei Huang Cc: QEMU Trivial , Igor Mammedov , Shannon Zhao , QEMU Developers , Shannon Zhao 01.02.2016 21:01, Peter Maydell wrote: > On 1 February 2016 at 17:20, Wei Huang wrote: >> This patch removes float_high field of PL061State, which doesn't seem >> to be used anywhere. [] >> @@ -88,7 +87,6 @@ static const VMStateDescription vmstate_pl061 = { >> VMSTATE_UINT32(slr, PL061State), >> VMSTATE_UINT32(den, PL061State), >> VMSTATE_UINT32(cr, PL061State), >> - VMSTATE_UINT32(float_high, PL061State), >> VMSTATE_UINT32_V(amsel, PL061State, 2), >> VMSTATE_END_OF_LIST() > > This would be a migration compatibility break, so at a minimum > you need to bump the vmstate struct versions. Is it worth the effort to remove this field if it causes compatibility break? Maybe keep it around, it doesn't hurt? At the very least, we may rename it to "unused_float_high", or something, to indicate it is a known-unused? Thanks, /mjt