From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754122AbcBBIOt (ORCPT ); Tue, 2 Feb 2016 03:14:49 -0500 Received: from a.ns.miles-group.at ([95.130.255.143]:11949 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753410AbcBBIOs (ORCPT ); Tue, 2 Feb 2016 03:14:48 -0500 Subject: =?UTF-8?B?UmU6IOetlOWkjTogW1BBVENIXSBzaWduYWw6IHVzZSBzaXplb2YoKSBp?= =?UTF-8?Q?nstead_of_sizeof?= To: Wei Tang , akpm@linux-foundation.org, oleg@redhat.com References: <1454398517-10631-1-git-send-email-tangwei@cmss.chinamobile.com> <56B060FB.90406@nod.at> <000001d15d90$f3c40a40$db4c1ec0$@cmss.chinamobile.com> Cc: amanieu@gmail.com, dave@stgolabs.net, vdavydov@parallels.com, palmer@dabbelt.com, linux-kernel@vger.kernel.org From: Richard Weinberger Message-ID: <56B06573.8090107@nod.at> Date: Tue, 2 Feb 2016 09:14:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <000001d15d90$f3c40a40$db4c1ec0$@cmss.chinamobile.com> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 02.02.2016 um 09:08 schrieb Wei Tang: > This is a simple patch, just to clear up the output from checkpatch.pl > script, otherwise, we will get WARNING always. This does not answer my question. What problem does it fix? How does your patch make the kernel better? Doing patches just because of checkpatch warnings (not errors) is IMHO not good. It is a script and not human, it does not understand all the corner cases. All it can do is giving us hints. But this does not mean that you have to blindly follow them. Thanks, //richard