All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Stephen Hemminger <shemming@brocade.com>,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"julien.floret@6wind.com" <julien.floret@6wind.com>
Subject: Re: [PATCH iproute2] tc: fix compilation with old gcc (< 4.6) (bis)
Date: Tue, 02 Feb 2016 10:08:38 +0100	[thread overview]
Message-ID: <56B07216.5080604@iogearbox.net> (raw)
In-Reply-To: <20160202155157.2f492bfd@samsung9>

On 02/02/2016 05:51 AM, Stephen Hemminger wrote:
> On Tue, 19 Jan 2016 11:01:45 +0000
> Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
>
>> diff --git a/tc/tc_bpf.c b/tc/tc_bpf.c
>> index 42c8841869f5..219ffa582c1a 100644
>> --- a/tc/tc_bpf.c
>> +++ b/tc/tc_bpf.c
>> @@ -49,6 +49,10 @@
>>   #include "tc_util.h"
>>   #include "tc_bpf.h"
>>
>> +#ifndef AF_ALG
>> +#define AF_ALG 38
>> +#endif
>
> Why is this here? AF_ALG is not used anywhere in this code.

It is used, this patch is fine as-is.

Thanks!

> Please remove it and resubmit

  reply	other threads:[~2016-02-02  9:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1f5ba49033cd4c55a0d0005487efde39@HQ1WP-EXMB11.corp.brocade.com>
2016-02-02  4:51 ` [PATCH iproute2] tc: fix compilation with old gcc (< 4.6) (bis) Stephen Hemminger
2016-02-02  9:08   ` Daniel Borkmann [this message]
2016-02-02 10:39     ` Nicolas Dichtel
2016-02-03  8:25       ` [RESEND PATCH " Nicolas Dichtel
     [not found]       ` <569e50f6be2b43c4a7e1483e295da271@HQ1WP-EXMB11.corp.brocade.com>
2016-02-05  0:50         ` Stephen Hemminger
2016-01-19 11:01 [PATCH " Nicolas Dichtel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B07216.5080604@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=julien.floret@6wind.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=shemming@brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.