From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hartley Subject: Re: [PATCH V3 2/2] reset: img: Add Pistachio reset controller driver Date: Tue, 2 Feb 2016 09:13:01 +0000 Message-ID: <56B0731D.6040605@imgtec.com> References: <1453122758-651-1-git-send-email-james.hartley@imgtec.com> <1453122758-651-3-git-send-email-james.hartley@imgtec.com> <1454359327.3447.77.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1454359327.3447.77.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Philipp Zabel Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Damien Horsley , Govindraj Raja List-Id: devicetree@vger.kernel.org Hi Philipp, Yes that all looks fine to me. Thanks, James. On 02/01/16 20:42, Philipp Zabel wrote: > Hi James, > > Thanks for the reminder. I'll apply these with a few small fixups. > No need to resend if you agree. > > Am Montag, den 18.01.2016, 13:12 +0000 schrieb James Hartley: >> From: "Damien.Horsley" > s/Damien.Horsley/Damien Horsley/ > >> Add reset controller driver for Pistachio SoC >> >> Signed-off-by: Damien.Horsley > Same here. > >> Signed-off-by: James Hartley >> --- >> drivers/reset/Makefile | 1 + >> drivers/reset/reset-pistachio.c | 155 ++++++++++++++++++++++++++ >> include/dt-bindings/reset/pistachio-resets.h | 36 ++++++ >> 3 files changed, 192 insertions(+) >> create mode 100644 drivers/reset/reset-pistachio.c >> create mode 100644 include/dt-bindings/reset/pistachio-resets.h > [...] >> diff --git a/drivers/reset/reset-pistachio.c b/drivers/reset/reset-pistachio.c >> new file mode 100644 >> index 0000000..8e39465 >> --- /dev/null >> +++ b/drivers/reset/reset-pistachio.c >> @@ -0,0 +1,155 @@ > [...] >> +static int pistachio_reset_assert(struct reset_controller_dev *rcdev, >> + unsigned long id) > This should be aligned to the open parenthesis. > > [...] >> +static int pistachio_reset_deassert(struct reset_controller_dev *rcdev, >> + unsigned long id) > And this. > > [...] >> +static int pistachio_reset_remove(struct platform_device *pdev) >> +{ >> + struct pistachio_reset_data *data = platform_get_drvdata(pdev); >> + >> + reset_controller_unregister(&data->rcdev); >> + >> + return 0; >> +} >> + >> + > And one of these empty lines has to go. > >> +static const struct of_device_id pistachio_reset_dt_ids[] = { >> + { .compatible = "img,pistachio-reset", }, >> + { /* sentinel */ }, >> +}; >> +MODULE_DEVICE_TABLE(of, pistachio_reset_dt_ids); >> + >> +static struct platform_driver pistachio_reset_driver = { >> + .probe = pistachio_reset_probe, >> + .remove = pistachio_reset_remove, >> + .driver = { >> + .name = "pistachio-reset", >> + .of_match_table = pistachio_reset_dt_ids, >> + }, >> +}; >> +module_platform_driver(pistachio_reset_driver); >> + >> +MODULE_AUTHOR("Damien Horsley "); > regards > Philipp > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754236AbcBBJMb (ORCPT ); Tue, 2 Feb 2016 04:12:31 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:5275 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754012AbcBBJM2 (ORCPT ); Tue, 2 Feb 2016 04:12:28 -0500 Message-ID: <56B0731D.6040605@imgtec.com> Date: Tue, 2 Feb 2016 09:13:01 +0000 From: James Hartley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: Philipp Zabel CC: , , Damien Horsley , Govindraj Raja Subject: Re: [PATCH V3 2/2] reset: img: Add Pistachio reset controller driver References: <1453122758-651-1-git-send-email-james.hartley@imgtec.com> <1453122758-651-3-git-send-email-james.hartley@imgtec.com> <1454359327.3447.77.camel@pengutronix.de> In-Reply-To: <1454359327.3447.77.camel@pengutronix.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.167.85] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp, Yes that all looks fine to me. Thanks, James. On 02/01/16 20:42, Philipp Zabel wrote: > Hi James, > > Thanks for the reminder. I'll apply these with a few small fixups. > No need to resend if you agree. > > Am Montag, den 18.01.2016, 13:12 +0000 schrieb James Hartley: >> From: "Damien.Horsley" > s/Damien.Horsley/Damien Horsley/ > >> Add reset controller driver for Pistachio SoC >> >> Signed-off-by: Damien.Horsley > Same here. > >> Signed-off-by: James Hartley >> --- >> drivers/reset/Makefile | 1 + >> drivers/reset/reset-pistachio.c | 155 ++++++++++++++++++++++++++ >> include/dt-bindings/reset/pistachio-resets.h | 36 ++++++ >> 3 files changed, 192 insertions(+) >> create mode 100644 drivers/reset/reset-pistachio.c >> create mode 100644 include/dt-bindings/reset/pistachio-resets.h > [...] >> diff --git a/drivers/reset/reset-pistachio.c b/drivers/reset/reset-pistachio.c >> new file mode 100644 >> index 0000000..8e39465 >> --- /dev/null >> +++ b/drivers/reset/reset-pistachio.c >> @@ -0,0 +1,155 @@ > [...] >> +static int pistachio_reset_assert(struct reset_controller_dev *rcdev, >> + unsigned long id) > This should be aligned to the open parenthesis. > > [...] >> +static int pistachio_reset_deassert(struct reset_controller_dev *rcdev, >> + unsigned long id) > And this. > > [...] >> +static int pistachio_reset_remove(struct platform_device *pdev) >> +{ >> + struct pistachio_reset_data *data = platform_get_drvdata(pdev); >> + >> + reset_controller_unregister(&data->rcdev); >> + >> + return 0; >> +} >> + >> + > And one of these empty lines has to go. > >> +static const struct of_device_id pistachio_reset_dt_ids[] = { >> + { .compatible = "img,pistachio-reset", }, >> + { /* sentinel */ }, >> +}; >> +MODULE_DEVICE_TABLE(of, pistachio_reset_dt_ids); >> + >> +static struct platform_driver pistachio_reset_driver = { >> + .probe = pistachio_reset_probe, >> + .remove = pistachio_reset_remove, >> + .driver = { >> + .name = "pistachio-reset", >> + .of_match_table = pistachio_reset_dt_ids, >> + }, >> +}; >> +module_platform_driver(pistachio_reset_driver); >> + >> +MODULE_AUTHOR("Damien Horsley "); > regards > Philipp >