From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQYXD-0007l7-MP for qemu-devel@nongnu.org; Tue, 02 Feb 2016 05:50:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQYX9-0003jQ-Lw for qemu-devel@nongnu.org; Tue, 02 Feb 2016 05:50:11 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:33449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQYX9-0003jM-FG for qemu-devel@nongnu.org; Tue, 02 Feb 2016 05:50:07 -0500 References: <1453743649-31581-1-git-send-email-peter.maydell@linaro.org> From: Leon Alrae Message-ID: <56B089D2.2030508@imgtec.com> Date: Tue, 2 Feb 2016 10:49:54 +0000 MIME-Version: 1.0 In-Reply-To: <1453743649-31581-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-mips: Stop using uint_fast*_t types in r4k_tlb_t struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , "qemu-devel@nongnu.org" Cc: Aurelien Jarno , "patches@linaro.org" On 25/01/16 17:40, Peter Maydell wrote: > The r4k_tlb_t structure uses the uint_fast*_t types. Most of these > uses are in bitfields and are thus pointless, because the bitfield > itself specifies the width of the type; just use 'unsigned int' > instead. (On glibc uint_fast16_t is defined as either 32 or 64 bits, > so we know the code is not reliant on it being exactly 16 bits.) > There is also one use of uint_fast8_t, which we replace with uint8_t, > because both are exactly 8 bits on glibc and this is the only > place outside the softfloat code which uses an int_fast*_t type. > > Signed-off-by: Peter Maydell > --- > I'm going to have a go at getting rid of the int_fast16_t usage > in the softfloat code too, but in the meantime this is an > independent cleanup. > > target-mips/cpu.h | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) Applied to target-mips tree, thanks. Leon