All of lore.kernel.org
 help / color / mirror / Atom feed
From: jiangyiwen <jiangyiwen@huawei.com>
To: lczerner@redhat.com
Cc: dm-devel@redhat.com, "Qijiang (Joseph,
	Euler)" <joseph.qi@huawei.com>,
	xuejiufei@huawei.com
Subject: Why don't return -EOPNOTSUPP?
Date: Tue, 2 Feb 2016 19:57:37 +0800	[thread overview]
Message-ID: <56B099B1.2060304@huawei.com> (raw)

Hi Lukas,
I have a question about commit 8af1954d172a("blkdev: Do not return
-EOPNOTSUPP if discard is supported"). That is we issue a
WRITE SAME request to device and return failed with EOPNOTSUPP,
but blkdev_issue_write_same ignore this error and return
success to caller. In this way, this will cause an inconsistent state
between upper layer and bottom layer.

I don't know why don't return EOPNOTSUPP if part of devices support
discard, because I think that blkdev_issue_discard should return
EOPNOTSUPP to caller even if some of devices support discard.

Thanks,
Yiwen Jiang.

             reply	other threads:[~2016-02-02 11:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 11:57 jiangyiwen [this message]
2016-02-02 13:58 ` Why don't return -EOPNOTSUPP? Lukáš Czerner
2016-02-03  4:03   ` jiangyiwen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B099B1.2060304@huawei.com \
    --to=jiangyiwen@huawei.com \
    --cc=dm-devel@redhat.com \
    --cc=joseph.qi@huawei.com \
    --cc=lczerner@redhat.com \
    --cc=xuejiufei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.