From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752811AbcBBNc4 (ORCPT ); Tue, 2 Feb 2016 08:32:56 -0500 Received: from mail-lf0-f47.google.com ([209.85.215.47]:33724 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752329AbcBBNcy (ORCPT ); Tue, 2 Feb 2016 08:32:54 -0500 Subject: Re: [PATCH 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine To: Joshua Henderson , linux-kernel@vger.kernel.org References: <1454373466-28733-1-git-send-email-joshua.henderson@microchip.com> <1454373466-28733-2-git-send-email-joshua.henderson@microchip.com> Cc: Cristian Birsan , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org From: Sergei Shtylyov Message-ID: <56B0B004.5020905@cogentembedded.com> Date: Tue, 2 Feb 2016 16:32:52 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454373466-28733-2-git-send-email-joshua.henderson@microchip.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/2/2016 3:37 AM, Joshua Henderson wrote: > From: Cristian Birsan > > Commit 6b6e97107f12f3a9f7 (USB: musb: fix isochronous TXDMA (take 2)) introduces Again, wrong commit style. And I really doubt that blaming my commit was correct. :-) > a problem setting the desired channel mode for the Mentor DMA engine. > > There is a case where the pointer of the channel DMA mode is incorrectly > assigned to a pointer value, when it should be assigned the actual mode value. > This results in the value of channel->desired_mode not being correct. > > Signed-off-by: Cristian Birsan > Signed-off-by: Joshua Henderson > --- > drivers/usb/musb/musb_host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c > index 3fdc99b..748379e 100644 > --- a/drivers/usb/musb/musb_host.c > +++ b/drivers/usb/musb/musb_host.c > @@ -662,7 +662,7 @@ static int musb_tx_dma_set_mode_mentor(struct dma_controller *dma, Hm, there was no such function at the time of my commit... > csr &= ~(MUSB_TXCSR_AUTOSET | MUSB_TXCSR_DMAMODE); > csr |= MUSB_TXCSR_DMAENAB; /* against programmer's guide */ > } > - channel->desired_mode = mode; > + channel->desired_mode = *mode; 'mode' was 'u8' at the time of my commit, see: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6b6e97107f12f3a9f7b5b43a6c3b94409240bcff I think that the recent commit below should be blamed instead: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=754fe4a92c072a6e36d89fa328ed789c9ebc1af5 [...] MBR, Sergei