All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Malahal Naineni <malahal@us.ibm.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] Ignore whitespace at the beginning of option tags
Date: Tue, 2 Feb 2016 10:24:52 -0500	[thread overview]
Message-ID: <56B0CA44.40105@RedHat.com> (raw)
In-Reply-To: <1454020727-1814-1-git-send-email-malahal@us.ibm.com>



On 01/28/2016 05:38 PM, Malahal Naineni wrote:
> The following should work now:
> 
> [General]
> 	Domain = local.domain.edu
> 
> Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
> ---
>  cfg.c | 9 ++++++++-
Ok.. I give... :-) What is this patch relative to? There is
a conf_parse_line() in support/nfs/conffile.c but there
is no cfg.c file in nfs-utils... and this patch does
not apply... 

steved.

>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/cfg.c b/cfg.c
> index c615d24..e0ab839 100644
> --- a/cfg.c
> +++ b/cfg.c
> @@ -210,6 +210,7 @@ static void
>  conf_parse_line (int trans, char *line, size_t sz)
>  {
>    char *val;
> +  char *tag;
>    size_t i;
>    int j;
>    static char *section = 0;
> @@ -262,8 +263,14 @@ conf_parse_line (int trans, char *line, size_t sz)
>  	/* Skip trailing whitespace, if any */
>  	for (j = sz - (val - line) - 1; j > 0 && isspace (val[j]); j--)
>  	  val[j] = '\0';
> +
> +	/* Skip beginning white space */
> +	tag = line;
> +	while (isspace(*tag))
> +		tag++;
> +
>  	/* XXX Perhaps should we not ignore errors?  */
> -	conf_set (trans, section, line, val, 0, 0);
> +	conf_set (trans, section, tag, val, 0, 0);
>  	return;
>        }
>  
> 

  reply	other threads:[~2016-02-02 15:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28 22:38 [PATCH] Ignore whitespace at the beginning of option tags Malahal Naineni
2016-02-02 15:24 ` Steve Dickson [this message]
2016-02-03 11:58   ` Benjamin Coddington
2016-02-04 23:29     ` Malahal Naineni
2016-02-09 16:00       ` Steve Dickson
2016-02-09 16:13         ` J. Bruce Fields
2016-02-11 18:02         ` Malahal Naineni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B0CA44.40105@RedHat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=malahal@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.