From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756611AbcBBQvi (ORCPT ); Tue, 2 Feb 2016 11:51:38 -0500 Received: from mail-lf0-f46.google.com ([209.85.215.46]:35840 "EHLO mail-lf0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756575AbcBBQvg (ORCPT ); Tue, 2 Feb 2016 11:51:36 -0500 Subject: Re: [PATCH 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine To: Joshua Henderson , linux-kernel@vger.kernel.org References: <1454373466-28733-1-git-send-email-joshua.henderson@microchip.com> <1454373466-28733-2-git-send-email-joshua.henderson@microchip.com> <56B0B004.5020905@cogentembedded.com> <56B0DAFD.50103@microchip.com> Cc: Cristian Birsan , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <56B0DE94.9020804@cogentembedded.com> Date: Tue, 2 Feb 2016 19:51:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56B0DAFD.50103@microchip.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/2016 07:36 PM, Joshua Henderson wrote: >>> From: Cristian Birsan >>> >>> Commit 6b6e97107f12f3a9f7 (USB: musb: fix isochronous TXDMA (take 2)) introduces >> >> Again, wrong commit style. Commit citing style, I meant. >> And I really doubt that blaming my commit was correct. :-) > > I apologize. I noticed you added the line in question, but did not notice the variable type of "mode" changed *afterward*. So I thought. :-) > Completely my fault. I shall also fix the commit message style. TIA. [...] > Thanks, > Josh MBR, Sergei