From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQeRI-0004HW-Fy for qemu-devel@nongnu.org; Tue, 02 Feb 2016 12:08:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQeRH-0001uF-A9 for qemu-devel@nongnu.org; Tue, 02 Feb 2016 12:08:28 -0500 References: From: Max Reitz Message-ID: <56B0E282.2060102@redhat.com> Date: Tue, 2 Feb 2016 18:08:18 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1nLt0flCvmguUw8Jw3wtmiF98JUbeKaMe" Subject: Re: [Qemu-devel] [PATCH v2 0/2] Active commit regression fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, qemu-stable@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1nLt0flCvmguUw8Jw3wtmiF98JUbeKaMe Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 02.02.2016 02:33, Jeff Cody wrote: > Changes from v1: >=20 > * Rather than allow insertion when bs->device_listtqe_prev points to > a NULL entry, make sure than we follow the block scheme of enforcing > bs->device_list->tqe_prev is NULL upon deletion. (Thanks Max!) >=20 > Bug #1300209 is a regression in 2.5, introduced during the=20 > change away from bdrv_swap(). >=20 > When we change the parent backing link (change_parent_backing_link), > we must also accomodate non-NULL tqe_prev pointers that point to a > NULL entry. Please see patch #1 for more details. >=20 > Jeff Cody (2): > block: set device_list.tqe_prev to NULL on BDS removal > block: qemu-iotests - add test for snapshot, commit, snapshot bug >=20 > block.c | 24 ++++++---- > blockdev.c | 3 +- > include/block/block.h | 1 + > tests/qemu-iotests/143 | 114 +++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/143.out | 24 ++++++++++ > tests/qemu-iotests/group | 1 + > 6 files changed, 155 insertions(+), 12 deletions(-) > create mode 100755 tests/qemu-iotests/143 > create mode 100644 tests/qemu-iotests/143.out Thanks, applied to my block tree: https://github.com/XanClic/qemu/commits/block Max --1nLt0flCvmguUw8Jw3wtmiF98JUbeKaMe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWsOKCAAoJEDuxQgLoOKytvJwH/1kYSuVro+y0P1c2h9zJwGiT 1rSX1PqCqaa+j1l6OLBbpMR9c90UuEMoUBWVjVg9CCiY4AIfzQLl23e3R6djvOQ4 yhNJ0LxZ6hdoybmF80bIYP6L0V7OE1RWXaf1I1+PHaGoMK5wfieUBou3ZS2ZXmrC Vs64yCm0p/anw5jk5FyD+NBGI+IZ98DMcMMg7xi9NGMYsZ5jjvQ17LmAZ7+WOg1d epaJRU8MxVBPyVEC5IlHkEtHq+e51aNVeSZ5t/IgOx3ui4eeZoK1uineirBg7QUB rSJvD/7m+ElqwcGXs2/RfPBfOWR5IXsMpOAg4zbZ9QGMqDO0x/fJg0C7uM7/XIM= =Pv1H -----END PGP SIGNATURE----- --1nLt0flCvmguUw8Jw3wtmiF98JUbeKaMe--