From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQf1G-0000vK-3b for qemu-devel@nongnu.org; Tue, 02 Feb 2016 12:45:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQf1E-00028O-Vi for qemu-devel@nongnu.org; Tue, 02 Feb 2016 12:45:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60968) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQf1E-00027c-O1 for qemu-devel@nongnu.org; Tue, 02 Feb 2016 12:45:36 -0500 References: <1454424701-26111-1-git-send-email-eblake@redhat.com> From: Eric Blake Message-ID: <56B0EB3E.9000001@redhat.com> Date: Tue, 2 Feb 2016 10:45:34 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="v40ce8NhmGnOAdVVuu88bA0O4Dum3qXEB" Subject: Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on MIPS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: James Hogan , Michael Roth , Peter Crosthwaite , QEMU Developers , Markus Armbruster , Luiz Capitulino , Paolo Bonzini , Richard Henderson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --v40ce8NhmGnOAdVVuu88bA0O4Dum3qXEB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/02/2016 10:26 AM, Peter Maydell wrote: > On 2 February 2016 at 14:51, Eric Blake wrote: >> Commit 86f4b687 broke compilation on MIPS, which has a preprocessor >> pollution of '#define mips 1'. Treat it the same way as we do for >> the pollution with 'unix', so that QMP remains backwards compatible >> and only the C code needs to use the alternative 'q_mips' spelling. >> >> CC: James Hogan >> Signed-off-by: Eric Blake >> --- >> # namespace pollution: >> - polluted_words =3D set(['unix', 'errno']) >> + polluted_words =3D set(['unix', 'errno', 'mips']) >> name =3D name.translate(c_name_trans) >> if protect and (name in c89_words | c99_words | c11_words | gcc_w= ords >> | cpp_words | polluted_words): >=20 > Looking at commit 86f4b687 I think we also need to add 'sparc' to the > polluted_words list (Solaris defines that). I would also be unsurprised= > to find that some PPC platforms define 'ppc'. (Tricore is probably > new enough to have escaped this namespace pollution and we don't > support it as a host CPU anyway.) Do we have anyone that can confirm on these platforms? Obviously, I proved that it's fairly easy to work around, and I don't mind doing the followup patch(es), but only if we have concrete cases where we know it is needed. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --v40ce8NhmGnOAdVVuu88bA0O4Dum3qXEB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWsOs+AAoJEKeha0olJ0NqsG0IAIbulNJoqqUD6v/zs6arzyy4 oCfMAeYrXI7rc4S4uFm5huMVa9OCrQ/2oNLwEoPG9xs+s/pq5vjAA/PH6xz7bjaG YVj4zwvtaX2MAyThBu1ojZtaasnMOfO9EwfPP5AVYClFE5ritkcGs3ZLZ0iYkhQx oeCHSoJ32T7yHY42GA71B0EkcRgRoJ7yjgkJl+p35jimOSLd6MLCdUxcxqVTpB6I yeu14KMUuFqfzXsWhhJDQzpieC61x8LAZPqQ+l2UTcHKsIJ1F17GrsUGGp5gZOBq eo45Lt70gQXA53FdLWSAaxf5f5UM8OyFqiX13S2mVJRZxYA7aSc+s4V0ovp6lJ0= =q+iL -----END PGP SIGNATURE----- --v40ce8NhmGnOAdVVuu88bA0O4Dum3qXEB--