From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38380)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1aQhAb-0002Gw-Gi
	for qemu-devel@nongnu.org; Tue, 02 Feb 2016 15:03:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1aQhAa-0000hJ-8x
	for qemu-devel@nongnu.org; Tue, 02 Feb 2016 15:03:25 -0500
From: John Snow <jsnow@redhat.com>
Message-ID: <56B10B86.4020505@redhat.com>
Date: Tue, 2 Feb 2016 15:03:18 -0500
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] iotest 013 failure under clang -fsanitize=undefined
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Qemu-block <qemu-block@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Laszlo Ersek <lersek@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>

Recently, qemu iotest 013 has started to fail for me:

Fedora release 22 (Twenty Two)

3.5.0-9.fc22
clang version 3.5.0 (tags/RELEASE_350/final)
Target: x86_64-redhat-linux-gnu
Thread model: posix


+4 KiB/home/jsnow/src/qemu/qemu-io-cmds.c:230:18: runtime error:
division by zero


The problem is that in the print report for read_f, t2 and t1 can
actually be the same exact timestamp, and tdiv will try to divide by 0.0.

Normally this is not a problem as this is defined to be INFINITY in C99
Annex F.

Clang, however, has once again decided to take the pedantic road and
state that Annex F is optional, and therefore division by 0.0 is
actually undefined when using -fsanitize=undefined.

Groan.

Two workarounds:

(1) Modify the tdiv() function to just return INFINITY manually if the
timestamp provided is 0

(2) Modify tester scripts to also use -fno-sanitize=float-divide-by-zero


I prepared a patch to do the first workaround [1] so I could test
patches with clang in peace as I need to test my pull requests under
clang to make sure I don't break OSX, but it seems so absurd to have to
do this, so I have copied our resident language lawyers (and language
pragmatists) so that they can have a say.

Relevant upstream BZ: https://llvm.org/bugs/show_bug.cgi?id=17000

--js

[1]
https://github.com/jnsnow/qemu/commit/af93977dd2bc7ea936b8064c41c5a0f9d25ae2d1