From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQkZT-00005Q-32 for qemu-devel@nongnu.org; Tue, 02 Feb 2016 18:41:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQkZS-0008Or-5B for qemu-devel@nongnu.org; Tue, 02 Feb 2016 18:41:19 -0500 References: <1454417864-18774-1-git-send-email-berrange@redhat.com> <1454417864-18774-2-git-send-email-berrange@redhat.com> <56B13DF4.5010006@redhat.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <56B13E92.3030709@suse.de> Date: Wed, 3 Feb 2016 00:41:06 +0100 MIME-Version: 1.0 In-Reply-To: <56B13DF4.5010006@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="V4T6XdRnBW9thEsshi1QJxoprWKiOVX1W" Subject: Re: [Qemu-devel] [PATCH v5 01/10] qom: add helpers for UserCreatable object types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --V4T6XdRnBW9thEsshi1QJxoprWKiOVX1W Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 03.02.2016 um 00:38 schrieb Eric Blake: > On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: >> The QMP monitor code has two helper methods object_add >> and qmp_object_del that are called from several places >> in the code (QMP, HMP and main emulator startup). >> >> The HMP and main emulator startup code also share >> further logic that extracts the qom-type & id >> values from a qdict. >> >> We soon need to use this logic from qemu-img, qemu-io >> and qemu-nbd too, but don't want those to depend on >> the monitor, nor do we want to duplicate the code. >=20 > Yay - merge conflicts with my work pending on Markus' qapi-next branch:= > https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg00254.html Did I review the wrong patch then? I assumed this was the one I was asked to look at just before FOSDEM... Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N= =C3=BCrnberg) --V4T6XdRnBW9thEsshi1QJxoprWKiOVX1W Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJWsT6YAAoJEPou0S0+fgE/AigP/0u8mCL9dGg3g/kaXBvBowsl lMIKdkPjpctMZvn0NytPfI96viY2FErPfZrwt1LFGUj4M58m31mxoVMZOzDhQ657 zDRLpbR1dof7uWjsjDcF6WLGMY+Yw/1lBYPI3t7S8TYZZ/6iANbo1vbOwVkd3Mki H6qd8ljF7Cx2s1Za3uqeypDU98hsRDrCKak0ppFM2x1+99kRl5NMf6rMIvy5P5ja y+H2DBFKoNO4qYcqFKJJ8zTNbdqAnehqon3c1pn8JB49xbSkma0PotObwO+1HaWF YPFQspwPHpcisOnZXZWCBzVHZIlFARLYq3tdSofsKHCU9yvRGiKD7OIy0loC7W0Y dug7KuOYRTFNsxumFJa5THzDdpx6pnrB2TBiPvw43HLVuzE6z94e+IxkTE5LTVv1 rC99pTm93MRpO52xnd3tveXDfgpjLjan3GnRCNejd/39lVFNJYe7MkMB8TMFQzAm dni++9QDtUmLxhSeM4Rvhr+lqPHGXE0isE4ifAAwZd8ali8z/v5yw5S+CA7fHr01 LWETeOgmWlDI9/RH2Y6vjH/+zNafXotnbejV5wqnJvgLBw58/sK/ghozgDdsheSX Z7FfZ15lmgw68zQ0qFVazCw9SFKO1RG6a/wFVyK9tq9CRJFYEfllfwgI9I0cVYcE wD2gtDxXPlDqIwAAiNEK =13rD -----END PGP SIGNATURE----- --V4T6XdRnBW9thEsshi1QJxoprWKiOVX1W--