From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com. [210.118.77.14]) by gmr-mx.google.com with ESMTPS id ui7si528362pab.0.2016.02.02.15.57.23 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 02 Feb 2016 15:57:24 -0800 (PST) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O1Y00E772JJAA80@mailout4.w1.samsung.com> for rtc-linux@googlegroups.com; Tue, 02 Feb 2016 23:57:19 +0000 (GMT) Subject: [rtc-linux] Re: [PATCH 1/4] rtc: max77686: fix checkpatch error To: Laxman Dewangan , lee.jones@linaro.org, alexandre.belloni@free-electrons.com, javier@osg.samsung.com References: <1454419012-18050-1-git-send-email-ldewangan@nvidia.com> <1454419012-18050-2-git-send-email-ldewangan@nvidia.com> Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com From: Krzysztof Kozlowski Message-id: <56B1425F.2080709@samsung.com> Date: Wed, 03 Feb 2016 08:57:19 +0900 MIME-version: 1.0 In-reply-to: <1454419012-18050-2-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 02.02.2016 22:16, Laxman Dewangan wrote: > Fix following check patch error in rtc-max77686 driver: > - Alignment should match open parenthesis. > - braces {} should be used on all arms of this statement. > - Prefer using the BIT macro > > Signed-off-by: Laxman Dewangan > --- > drivers/rtc/rtc-max77686.c | 25 +++++++++++++------------ > 1 file changed, 13 insertions(+), 12 deletions(-) > Reviewed-by: Krzysztof Kozlowski Tested on Trats2/max77686: Tested-by: Krzysztof Kozlowski Best regards, Krzysztof -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755215AbcBBX5X (ORCPT ); Tue, 2 Feb 2016 18:57:23 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:12818 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754087AbcBBX5V (ORCPT ); Tue, 2 Feb 2016 18:57:21 -0500 X-AuditID: cbfec7f4-f79026d00000418a-4b-56b1425f8bbf Subject: Re: [PATCH 1/4] rtc: max77686: fix checkpatch error To: Laxman Dewangan , lee.jones@linaro.org, alexandre.belloni@free-electrons.com, javier@osg.samsung.com References: <1454419012-18050-1-git-send-email-ldewangan@nvidia.com> <1454419012-18050-2-git-send-email-ldewangan@nvidia.com> Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <56B1425F.2080709@samsung.com> Date: Wed, 03 Feb 2016 08:57:19 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1454419012-18050-2-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRmVeSWpSXmKPExsVy+t/xq7rxThvDDJ484rTouLaYyeL6l+es Fm/ermGyeP3C0GLpvtUsFve/HmW0uLxrDpvF/s4ORgcOjyebLjJ67Jl4ks3jzrU9bB69ze/Y PLb032X36NuyitHj8ya5APYoLpuU1JzMstQifbsErozjvW9YCp6yVHS/M2pg/MncxcjJISFg IrFk018mCFtM4sK99WxdjFwcQgJLGSVmHGlhhXCeMkrsufWLEaRKWMBG4tWD1ywgCRGBBkaJ zzdfg40SEqiX+PVlCQuIzSwQKnHh5XWwOJuAscTm5UvYIFbISfR2TwKr4RXQklh1bz4riM0i oCrxcvU9sBpRgQiJw51d7BA1ghI/Jt8Dq+cUcJVY+e0AkM0BNF9P4v5FLYhV8hKb17xlnsAo OAtJxyyEqllIqhYwMq9iFE0tTS4oTkrPNdQrTswtLs1L10vOz93ECImLLzsYFx+zOsQowMGo xMPL8GNDmBBrYllxZe4hRgkOZiURXmO5jWFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeefueh8i JJCeWJKanZpakFoEk2Xi4JRqYIzO//rYfjl/hOHzP/2fEszUpfdZHPrMJr1Goi7uuEGM40Xz jbJ7E14e4Hb8K+iQG3DEou7i+av2h1gW31UxSLLZ9+TpgXehbJNucG8M9VgVsK7Js8Hn+fQ3 992qTThuLd23P4efa0Uzz3r3qCzjdQqLrhQtt18rfJvTaLHCzQsWcjotwi6Rt5VYijMSDbWY i4oTAdjH8PSHAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.02.2016 22:16, Laxman Dewangan wrote: > Fix following check patch error in rtc-max77686 driver: > - Alignment should match open parenthesis. > - braces {} should be used on all arms of this statement. > - Prefer using the BIT macro > > Signed-off-by: Laxman Dewangan > --- > drivers/rtc/rtc-max77686.c | 25 +++++++++++++------------ > 1 file changed, 13 insertions(+), 12 deletions(-) > Reviewed-by: Krzysztof Kozlowski Tested on Trats2/max77686: Tested-by: Krzysztof Kozlowski Best regards, Krzysztof