From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.s-osg.org (lists.s-osg.org. [54.187.51.154]) by gmr-mx.google.com with ESMTP id ui7si608875pab.0.2016.02.02.19.08.23 for ; Tue, 02 Feb 2016 19:08:23 -0800 (PST) Subject: [rtc-linux] Re: [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers To: Laxman Dewangan , lee.jones@linaro.org, alexandre.belloni@free-electrons.com, k.kozlowski@samsung.com References: <1454419012-18050-1-git-send-email-ldewangan@nvidia.com> <1454419012-18050-3-git-send-email-ldewangan@nvidia.com> Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com From: Javier Martinez Canillas Message-ID: <56B16F20.70104@osg.samsung.com> Date: Wed, 3 Feb 2016 00:08:16 -0300 MIME-Version: 1.0 In-Reply-To: <1454419012-18050-3-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hello Laxman On 02/02/2016 10:16 AM, Laxman Dewangan wrote: > rtc_regmap should be used to access all RTC regsiters instead s/regsiters/registers > of parent regmap regardless of what chip or property have it. > > This makes the register access uniform and extendible for other > chips. > > Signed-off-by: Laxman Dewangan > CC: Krzysztof Kozlowski > CC: Javier Martinez Canillas > --- > drivers/rtc/rtc-max77686.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > Thanks for the patch, I indeed should had used rtc_regmap for consistency. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932782AbcBCDIY (ORCPT ); Tue, 2 Feb 2016 22:08:24 -0500 Received: from lists.s-osg.org ([54.187.51.154]:52542 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932293AbcBCDIX (ORCPT ); Tue, 2 Feb 2016 22:08:23 -0500 Subject: Re: [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers To: Laxman Dewangan , lee.jones@linaro.org, alexandre.belloni@free-electrons.com, k.kozlowski@samsung.com References: <1454419012-18050-1-git-send-email-ldewangan@nvidia.com> <1454419012-18050-3-git-send-email-ldewangan@nvidia.com> Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com From: Javier Martinez Canillas Message-ID: <56B16F20.70104@osg.samsung.com> Date: Wed, 3 Feb 2016 00:08:16 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1454419012-18050-3-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Laxman On 02/02/2016 10:16 AM, Laxman Dewangan wrote: > rtc_regmap should be used to access all RTC regsiters instead s/regsiters/registers > of parent regmap regardless of what chip or property have it. > > This makes the register access uniform and extendible for other > chips. > > Signed-off-by: Laxman Dewangan > CC: Krzysztof Kozlowski > CC: Javier Martinez Canillas > --- > drivers/rtc/rtc-max77686.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > Thanks for the patch, I indeed should had used rtc_regmap for consistency. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America