From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aQrd0-0008M4-Ea for mharc-qemu-trivial@gnu.org; Wed, 03 Feb 2016 02:13:26 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQrcx-0008Hx-N3 for qemu-trivial@nongnu.org; Wed, 03 Feb 2016 02:13:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQrcw-00029i-R8 for qemu-trivial@nongnu.org; Wed, 03 Feb 2016 02:13:23 -0500 Received: from isrv.corpit.ru ([86.62.121.231]:57049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQrcr-00028n-1j; Wed, 03 Feb 2016 02:13:17 -0500 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id C042D403BC; Wed, 3 Feb 2016 10:13:16 +0300 (MSK) To: Cao jin , qemu-devel@nongnu.org References: <1454469583-15753-1-git-send-email-caoj.fnst@cn.fujitsu.com> From: Michael Tokarev Openpgp: id=6EE195D1886E8FFB810D4324457CE0A0804465C5 Organization: Telecom Service, JSC Message-ID: <56B1A88C.6020604@msgid.tls.msk.ru> Date: Wed, 3 Feb 2016 10:13:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <1454469583-15753-1-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, imammedo@redhat.com, mst@redhat.com Subject: Re: [Qemu-trivial] [PATCH] Fix inconsistency between comment and variable name X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Feb 2016 07:13:24 -0000 03.02.2016 06:19, Cao jin wrote: > Signed-off-by: Cao jin > --- > include/hw/qdev-core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > index abcdee8..42fa5db 100644 > --- a/include/hw/qdev-core.h > +++ b/include/hw/qdev-core.h > @@ -221,7 +221,7 @@ typedef struct BusChild { > =20 > /** > * BusState: > - * @hotplug_device: link to a hotplug device associated with bus. > + * @hotplug_handler: link to a hotplug device associated with bus. Hmm. Now while the field name in comment and in the structure do match, the comment is still wrong, since it is a linke to a handler, not a device=85 :) Thanks, /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQrcv-0008Hm-SP for qemu-devel@nongnu.org; Wed, 03 Feb 2016 02:13:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQrcr-00028t-9Y for qemu-devel@nongnu.org; Wed, 03 Feb 2016 02:13:21 -0500 References: <1454469583-15753-1-git-send-email-caoj.fnst@cn.fujitsu.com> From: Michael Tokarev Message-ID: <56B1A88C.6020604@msgid.tls.msk.ru> Date: Wed, 3 Feb 2016 10:13:16 +0300 MIME-Version: 1.0 In-Reply-To: <1454469583-15753-1-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Fix inconsistency between comment and variable name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, imammedo@redhat.com, mst@redhat.com 03.02.2016 06:19, Cao jin wrote: > Signed-off-by: Cao jin > --- > include/hw/qdev-core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > index abcdee8..42fa5db 100644 > --- a/include/hw/qdev-core.h > +++ b/include/hw/qdev-core.h > @@ -221,7 +221,7 @@ typedef struct BusChild { > =20 > /** > * BusState: > - * @hotplug_device: link to a hotplug device associated with bus. > + * @hotplug_handler: link to a hotplug device associated with bus. Hmm. Now while the field name in comment and in the structure do match, the comment is still wrong, since it is a linke to a handler, not a device=85 :) Thanks, /mjt