From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755474AbcBCIyZ (ORCPT ); Wed, 3 Feb 2016 03:54:25 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37109 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbcBCIyX (ORCPT ); Wed, 3 Feb 2016 03:54:23 -0500 Subject: Re: [PATCH 1/2] lightnvm: warn if irqs are disabled in lock laddr To: =?UTF-8?Q?Javier_Gonz=c3=a1lez?= References: <1454322873-28687-1-git-send-email-javier@javigon.com> Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, =?UTF-8?Q?Javier_Gonz=c3=a1lez?= From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <56B1C03D.70203@lightnvm.io> Date: Wed, 3 Feb 2016 09:54:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1454322873-28687-1-git-send-email-javier@javigon.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/01/2016 11:34 AM, Javier González wrote: > Add a warning if irqs are disabled when locking a new address in rrpc. > The typical path to a new request does not disable irqs, but this is not > guaranteed in the future. > > Signed-off-by: Javier González > --- > drivers/lightnvm/rrpc.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/lightnvm/rrpc.h b/drivers/lightnvm/rrpc.h > index dfca5c4..c27283a 100644 > --- a/drivers/lightnvm/rrpc.h > +++ b/drivers/lightnvm/rrpc.h > @@ -184,6 +184,8 @@ static int __rrpc_lock_laddr(struct rrpc *rrpc, sector_t laddr, > sector_t laddr_end = laddr + pages - 1; > struct rrpc_inflight_rq *rtmp; > > + WARN_ON(irqs_disabled()); > + > spin_lock_irq(&rrpc->inflights.lock); > list_for_each_entry(rtmp, &rrpc->inflights.reqs, list) { > if (unlikely(request_intersects(rtmp, laddr, laddr_end))) { > Thanks, applied for next -rc.