From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail01.prevas.se ([62.95.78.3]:56678 "EHLO mail01.prevas.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751664AbcBCJ3Z (ORCPT ); Wed, 3 Feb 2016 04:29:25 -0500 Subject: Re: [PATCH 1/2] iio: ad5755: add support for dt bindings To: Lars-Peter Clausen , References: <1454416574-6645-1-git-send-email-sean.nyekjaer@prevas.dk> <56B0CC2C.6020809@metafoo.de> <56B0D203.3050905@prevas.dk> <56B0DB5E.7060608@metafoo.de> CC: From: =?UTF-8?Q?Sean_Nyekj=c3=a6r?= Message-ID: <56B1C871.6070105@prevas.dk> Date: Wed, 3 Feb 2016 10:29:21 +0100 MIME-Version: 1.0 In-Reply-To: <56B0DB5E.7060608@metafoo.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 2016-02-02 17:37, Lars-Peter Clausen wrote: > On 02/02/2016 04:57 PM, Sean Nyekjær wrote: >> >> On 2016-02-02 16:33, Lars-Peter Clausen wrote: >>> On 02/02/2016 01:36 PM, Sean Nyekjaer wrote: >>>> Still missing a way to provide default modes and settings >>>> for the driver from dt, but I see this as a start. >>>> >>>> Signed-off-by: Sean Nyekjaer >>> Hi, >>> >>> Thanks for the patch. >> :-) >>>> --- >>>> drivers/iio/dac/ad5755.c | 10 ++++++++++ >>>> 1 file changed, 10 insertions(+) >>>> >>>> diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c >>>> index bfb350a..e1b6e78 100644 >>>> --- a/drivers/iio/dac/ad5755.c >>>> +++ b/drivers/iio/dac/ad5755.c >>>> @@ -607,6 +607,16 @@ static const struct spi_device_id ad5755_id[] = { >>>> }; >>>> MODULE_DEVICE_TABLE(spi, ad5755_id); >>>> +static const struct of_device_id ad5755_of_match[] = { >>>> + { .compatible = "adi,ad5755" }, >>>> + { .compatible = "adi,ad5755-1" }, >>>> + { .compatible = "adi,ad5757" }, >>>> + { .compatible = "adi,ad5735" }, >>>> + { .compatible = "adi,ad5737" }, >>> This needs to set the ID for the device type, so that the driver gets >>> instantiated for the correct devicetype. And in the probe function check if >>> the driver was probed via DT (by checking spi->dev.of_node) and if it does >>> get the ID from the of_device_id rather the spi_device_id. If I probe the driver via DT the spi_get_device_id(spi)->driver_data returns the type... So this works as it is :-) I'll continue with the proposal... >> I was planning on doing that. >> And I was experimenting with providing modes and settings for every channel >> from the dt. >> Is the DAC the only output devices in IIO? > There is also support for programmable potentiometers (sometimes called > RDAC), but that's it. > >> I will send an proposal tomorrow :-) And thereby (maybe) pave the way for >> the runtime mode switching >> >> Should we drop the platform data support and only rely on dt? > No, there might still be some people depending on it. I don't think the > burden of continuing to maintain the platform data support is that high. > > - Lars From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Sean_Nyekj=c3=a6r?= Subject: Re: [PATCH 1/2] iio: ad5755: add support for dt bindings Date: Wed, 3 Feb 2016 10:29:21 +0100 Message-ID: <56B1C871.6070105@prevas.dk> References: <1454416574-6645-1-git-send-email-sean.nyekjaer@prevas.dk> <56B0CC2C.6020809@metafoo.de> <56B0D203.3050905@prevas.dk> <56B0DB5E.7060608@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <56B0DB5E.7060608-Qo5EllUWu/uELgA04lAiVw@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lars-Peter Clausen , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 2016-02-02 17:37, Lars-Peter Clausen wrote: > On 02/02/2016 04:57 PM, Sean Nyekj=E6r wrote: >> >> On 2016-02-02 16:33, Lars-Peter Clausen wrote: >>> On 02/02/2016 01:36 PM, Sean Nyekjaer wrote: >>>> Still missing a way to provide default modes and settings >>>> for the driver from dt, but I see this as a start. >>>> >>>> Signed-off-by: Sean Nyekjaer >>> Hi, >>> >>> Thanks for the patch. >> :-) >>>> --- >>>> drivers/iio/dac/ad5755.c | 10 ++++++++++ >>>> 1 file changed, 10 insertions(+) >>>> >>>> diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c >>>> index bfb350a..e1b6e78 100644 >>>> --- a/drivers/iio/dac/ad5755.c >>>> +++ b/drivers/iio/dac/ad5755.c >>>> @@ -607,6 +607,16 @@ static const struct spi_device_id ad5755_id[]= =3D { >>>> }; >>>> MODULE_DEVICE_TABLE(spi, ad5755_id); >>>> +static const struct of_device_id ad5755_of_match[] =3D { >>>> + { .compatible =3D "adi,ad5755" }, >>>> + { .compatible =3D "adi,ad5755-1" }, >>>> + { .compatible =3D "adi,ad5757" }, >>>> + { .compatible =3D "adi,ad5735" }, >>>> + { .compatible =3D "adi,ad5737" }, >>> This needs to set the ID for the device type, so that the driver ge= ts >>> instantiated for the correct devicetype. And in the probe function = check if >>> the driver was probed via DT (by checking spi->dev.of_node) and if = it does >>> get the ID from the of_device_id rather the spi_device_id. If I probe the driver via DT the spi_get_device_id(spi)->driver_data=20 returns the type... So this works as it is :-) I'll continue with the proposal... >> I was planning on doing that. >> And I was experimenting with providing modes and settings for every = channel >> from the dt. >> Is the DAC the only output devices in IIO? > There is also support for programmable potentiometers (sometimes call= ed > RDAC), but that's it. > >> I will send an proposal tomorrow :-) And thereby (maybe) pave the wa= y for >> the runtime mode switching >> >> Should we drop the platform data support and only rely on dt? > No, there might still be some people depending on it. I don't think t= he > burden of continuing to maintain the platform data support is that hi= gh. > > - Lars