Re: [PATCH] pci: fix typo in nvkm_pcie_set_link()

From: Samuel Pitoiset <samuel.pitoiset-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Alexandre Courbot
	<acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] pci: fix typo in nvkm_pcie_set_link()
Date: Wed, 3 Feb 2016 11:03:42 +0100	[thread overview]
Message-ID: <56B1D07E.1030704@gmail.com> (raw)
In-Reply-To: <1454491991-5839-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 02/03/2016 10:33 AM, Alexandre Courbot wrote:
> Fix a test that would either do nothing on PCI systems, or crash badly
> on Tegra.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> Cc: Karol Herbst <nouveau@karolherbst.de>
> ---
>   drm/nouveau/nvkm/subdev/pci/pcie.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drm/nouveau/nvkm/subdev/pci/pcie.c b/drm/nouveau/nvkm/subdev/pci/pcie.c
> index b32954f5311e..d71e5db5028a 100644
> --- a/drm/nouveau/nvkm/subdev/pci/pcie.c
> +++ b/drm/nouveau/nvkm/subdev/pci/pcie.c
> @@ -119,7 +119,7 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum nvkm_pcie_speed speed, u8 width)
>   	struct pci_bus *pbus;
>   	int ret;
>
> -	if (pci || !pci_is_pcie(pci->pdev))
> +	if (!pci || !pci_is_pcie(pci->pdev))
>   		return 0;
>   	pbus = pci->pdev->bus;

This has already been fixed but Ben still didn't apply this change to 
his repository.

http://cgit.freedesktop.org/~airlied/linux/tree/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c?h=drm-next#n122

>
>

-- 
-Samuel
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau