From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQzE4-00028m-Vd for qemu-devel@nongnu.org; Wed, 03 Feb 2016 10:20:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQzDz-0002kC-V4 for qemu-devel@nongnu.org; Wed, 03 Feb 2016 10:20:12 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:56728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQzDz-0002je-MU for qemu-devel@nongnu.org; Wed, 03 Feb 2016 10:20:07 -0500 References: <1454494453-20738-1-git-send-email-glaubitz@physik.fu-berlin.de> <1454494453-20738-2-git-send-email-glaubitz@physik.fu-berlin.de> <56B219E4.2070800@redhat.com> From: Laurent Vivier Message-ID: <56B21A9D.8080000@vivier.eu> Date: Wed, 3 Feb 2016 16:19:57 +0100 MIME-Version: 1.0 In-Reply-To: <56B219E4.2070800@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , John Paul Adrian Glaubitz , qemu-devel@nongnu.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Le 03/02/2016 16:16, Eric Blake a écrit : > On 02/03/2016 03:14 AM, John Paul Adrian Glaubitz wrote: >> Signed-off-by: John Paul Adrian Glaubitz >> --- target-m68k/translate.c | 4 >> ++++ 1 file changed, 4 insertions(+) >> >> diff --git a/target-m68k/translate.c b/target-m68k/translate.c >> index 535d7f9..a989961 100644 --- a/target-m68k/translate.c +++ >> b/target-m68k/translate.c @@ -2828,6 +2828,10 @@ register_opcode >> (disas_proc proc, uint16_t opcode, uint16_t mask) Later insn >> override earlier ones. */ void register_m68k_insns (CPUM68KState >> *env) { + /* Build the opcode table only once to avoid + >> multithreading issues. */ + if (opcode_table[0] != NULL) + >> return; > > Missing {}. Are you sure this is the version that passed > checkpatch.pl? It seems checkpatch.pl doesn't ask for this anymore. > >> #define INSN(name, opcode, mask, feature) do { \ if >> (m68k_feature(env, M68K_FEATURE_##feature)) \ >> register_opcode(disas_##name, 0x##opcode, 0x##mask); \ >> > Laurent -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWshqdAAoJEPMMOL0/L748AQUP/jKv0x4FC8MSqRKJjiL27O1O rQ98JqbZPaykz+wXRvRM6ZD5NEUE/PdDXQbzq3iVAJZFMXzMjv1RgOXVAVhhZRCr 3P6qv9hTzWoqrBDXHGEI0ACiTZwtWOd630SMr1Xz91WKkM9Iet7ULazmg+GinRv/ 5fzn0YoJ9f8WBahkAW1NYZk1dlJKKab2N8hYcbOiWj0PiwyGd4mGJZrpPrbNYzCL cnuRqSbJvBB+hyzWNYdLRdAcvLbpuYcKUltPDry3aYdkpTw7zS+iFQBe4E69j70h 7qtEyv2sIqQ2cgidWKAZPJ8l/jtUST82qfD0bGigELBKIaSE3+FVzim87WDpnB46 joeglUTU+TEBrY+FDyhNZtOB+XIfOoG2YVUQEVyDnFeBZP+XQWprrI1D318sAv/a P0Huv3Fije52SUGLSHfP03Z6CYmYV4Gp113XVX6qOJoqSq/2P0ML3sWpwb/fppwF VSykpdxUPGtHi+fh8o9VSVW5wwY3LrbfNriGs0bB8XDas6EdhpFmgXO07TC4OosI aCy3OT56rM4FdmbcdSL7nzD9IG4e0GRGcNEzKOlBDcGt8/NGxIEOyKz/gv7piSLB zLpKnyMFVn2FEUldhf6AmEl6L3huUzjlbWWylu8YPkjIqVOjSi5qZLH6j9C3a4zk R9OOqSJXGKW7xelPgYpP =zXmA -----END PGP SIGNATURE-----