From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR0PV-0001YV-6t for qemu-devel@nongnu.org; Wed, 03 Feb 2016 11:36:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aR0PU-0008Oq-Dj for qemu-devel@nongnu.org; Wed, 03 Feb 2016 11:36:05 -0500 References: <1454464341-9494-1-git-send-email-famz@redhat.com> <1454464341-9494-2-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <56B22C6B.9010401@redhat.com> Date: Wed, 3 Feb 2016 17:35:55 +0100 MIME-Version: 1.0 In-Reply-To: <1454464341-9494-2-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FjKQ1vHItnEida3X3nvbl99IPlw4iKCli" Subject: Re: [Qemu-devel] [PATCH v11 1/2] mirror: Rewrite mirror_iteration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , pbonzini@redhat.com, Jeff Cody , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FjKQ1vHItnEida3X3nvbl99IPlw4iKCli Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 03.02.2016 02:52, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. >=20 > Rewrite mirror_iteration to fix both flaws. >=20 > The output of iotests 109 is updated because we now report the offset > and len slightly differently in mirroring progress. >=20 > Signed-off-by: Fam Zheng > --- > block/mirror.c | 335 +++++++++++++++++++++++++++----------= -------- > tests/qemu-iotests/109.out | 80 +++++------ > trace-events | 1 - > 3 files changed, 243 insertions(+), 173 deletions(-) Reviewed-by: Max Reitz --FjKQ1vHItnEida3X3nvbl99IPlw4iKCli Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWsixrAAoJEDuxQgLoOKytFqYH/121RfAWOsKEhrMdU5cKgXJ1 pB6HdF0l7hbLdNp9qp1V61+FFt4GmYZaNO9XFAlGYhJC/mpE2hr8u5PmLHsPQ8GK LkGCt+iteesSlbinJ5Pz1/Kha2w4rkdyvNqcGQ4S9nryGqY+ZDyOzdthxcGF97C7 VlnUOGtUg57sxfb3qz7vNdvTnAxYijvpokU2YNxag5DjBHyn7bu3se58oTneaSN/ lmDQAAJqUZ7QfA5j8pHQu7e91HRLyTcsZ/sGbZAXuhSN4e7IloYLK1cKFZ2+B9mK 1zTTAegaf1km58EgeM+Jd0oC2qvHneJoEh4vjajGVJLGago+Z/53AqxxadHFEus= =ObDI -----END PGP SIGNATURE----- --FjKQ1vHItnEida3X3nvbl99IPlw4iKCli--