Re: platform: Do not detach from PM domains on shutdown

[Sinan Kaya <okaya@codeaurora.org>]

Hi Rafael,

On 2/2/2016 7:53 PM, Rafael J. Wysocki wrote:
> Hi,
> 
> On Tue, Feb 2, 2016 at 3:38 PM, Sinan Kaya <okaya@codeaurora.org> wrote:
>> Hi Rafael,Ulf;
>>
>> Following up to these patches on linux 4.5-rc1,
>>
>> commit 2d30bb0b3889adf09b342722b2ce596c0763bc93
>> Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> Date:   Tue Jan 12 00:12:19 2016 +0100
>>
>>     platform: Do not detach from PM domains on shutdown
>>
>>     Shutdown is carried out when the driver is still bound to the
>>     device, so it is incorrect to detach it from a PM domain (if any)
>>     at this point.
>>
>>     Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>     Reported-and-tested-by: Fabio Estevam <fabio.estevam@nxp.com>
>>     Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
>>
>>
>>
>> From Tomeu Vizoso <>
>> Subject [PATCH v11 2/4] PM / Domains: add setter for dev.pm_domain
>> Date Tue, 27 Oct 2015 15:38:49 +0100
>>
>> I'm seeing a problem with HIDMA driver during
>> unbind. I recognize that you fixed the issue for shutdown but the issue seems to be still there for
>> the remove case.
>>
>> I'm wondering if you need to remove this too.
> 
> This patch may help here: https://patchwork.kernel.org/patch/8170821/
> 
> Can you try it please?
> 
> Thanks,
> Rafael
> 

Your patch worked. You can add this if you have not merged already.

Tested-by: okaya@codeaurora.org

enablement: booted suscessfully
Starting logging: OK
Starting mdev...
Starting irqbalance: OK
Initializing random number generator... [    9.806670] random: dd urandom read with
done.
Starting system message bus: done
Starting network...
Starting dropbear sshd: OK
Starting telnetd: OK
Starting libvirtd: OK

/_#_echo_vfio-platform |tee -a /sys/bus/platform/devices/QCOM8061:00/driver_override
vfio-platform
/ # echo QCOM8061:00 | tee -a  /sys/bus/platform/devices/QCOM8061:00/driver/unbind
QCOM8061:00
[  148.846481] hidma QCOM8061:00: HI-DMA engine removed


/# echo QCOM8061:00 |tee -a /sys/bus/platform/drivers_probe
QCOM8061:00

/#
/#



-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project