From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR2Q8-0003O7-H1 for qemu-devel@nongnu.org; Wed, 03 Feb 2016 13:44:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aR2Q5-0005lJ-B2 for qemu-devel@nongnu.org; Wed, 03 Feb 2016 13:44:52 -0500 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:37477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR2Q5-0005l1-3u for qemu-devel@nongnu.org; Wed, 03 Feb 2016 13:44:49 -0500 Received: by mail-wm0-x22a.google.com with SMTP id l66so84223384wml.0 for ; Wed, 03 Feb 2016 10:44:48 -0800 (PST) Sender: Paolo Bonzini References: <1453465198-11000-1-git-send-email-lprosek@redhat.com> <20160203123639.GA20527@grmbl.mre> From: Paolo Bonzini Message-ID: <56B24A9C.9010104@redhat.com> Date: Wed, 3 Feb 2016 19:44:44 +0100 MIME-Version: 1.0 In-Reply-To: <20160203123639.GA20527@grmbl.mre> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] rng-random: implement request queue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah , Ladi Prosek Cc: pagupta@redhat.com, qemu-devel@nongnu.org On 03/02/2016 13:36, Amit Shah wrote: > ... and this can lead to breaking migration (the queue of requests on > the host needs to be migrated, else the new host will have no idea of > the queue). It is already migrated as part of virtio_rng_save's call to virtio_save. On the loading side, virtio_rng_process condenses all requests into one and chr_read fills in as many virtqueue buffers as possible from the single request. Cancel_requests seems useless. Paolo